[LinuxBIOS] [PATCH] flashrom patch for iwill dk8_htx

Luc Verhaegen libv at skynet.be
Fri Apr 27 13:25:11 CEST 2007


On Fri, Apr 27, 2007 at 01:17:27PM +0200, Luc Verhaegen wrote:
> On Fri, Apr 27, 2007 at 01:01:19PM +0200, Mondrian Nuessle wrote:
> > The attached patch enables flashing on the Iwill DK8-HTX board.
> > Basically, it configures the SuperIO to set the right GPIO pins, so
> > write protection is disabled.
> > 
> > Signed-off-by: Mondrian Nuessle <nuessle at uni-mannheim.de>
> > ---
> > 
> > Ok, this is the third try :-)
> > 
> > Regards,
> > Mondrian
> 
> > +	/* set GPIO regs... */
> > +	outb(0x2b, EFIR);	/* GPIO multiplexed pin reg. */
> > +	b = inb(EFDR) | 0xd0;
> > +	outb(0x2b, EFIR);
> > +	outb(b, EFDR);
> 
> Is it really necessary to write the index register twice here? Not that 
> it matters much in codesize.
> 
I would like an answer there, just for reference, so don't worry about 
it patchwise :)

Acked-by: Luc Verhaegen <libv at skynet.be>

Luc Verhaegen.




More information about the coreboot mailing list