[LinuxBIOS] [PATCH] flashrom patch for iwill dk8_htx

Luc Verhaegen libv at skynet.be
Thu Apr 26 22:12:33 CEST 2007

On Thu, Apr 26, 2007 at 06:24:06PM +0200, Mondrian Nuessle wrote:
> The attached patch enables flashing on the Iwill DK8-HTX board.
> Basically, it configures the SuperIO to set the right GPIO pins, so
> write protection is disabled.
> Signed-off-by: Mondrian Nuessle <nuessle at uni-mannheim.de>
> ---
> So, this is the second try :-)
> Only pci vendor id/device id is given, no subsystem id. Therefor,
> flashing when booted from factory BIOS will only work, if -m
> iwill:dk8_htx switch is given. I guess this could go in the wiki doc to
> this board...
> Regards,
> Mondrian

Ok, first some whitespace gestapoing.

There are 3 trailing whitespaces on empty lines. You probably also 
want to review comments. There's one place (GPIO inversion reg) where 
you start the line with spaces instead of a tab. Also, get a space in 
after a ',' in your in/outbs (activate logical device).

Is it really necessary to write the index register twice on the w83627?

> +        { 0x1022, 0x7468, 0x0, 0x0,  0x0, 0x0, 0x0, 0x0,
> +		"iwill", "dk8_htx", "IWILL DK8-HTX", board_iwill_dk8htx },

There is a hard strcmp in the linuxbios name matching. For the agami 
aruma, the linuxbios name is in all caps, but here it is in small 
letters. Is this correct, as in, does this correspond with the 
linuxbios config? Should board_enable be using strcasecmp?

As for documenting, README should be touched as well. You might want to 
add the AGAMI:ARUMA.

This name matching is rather safe now, as you have to match at least one 
set of main pci-ids. This will stop joe simple from simply running down 
the list of board enables.

Luc Verhaegen.

More information about the coreboot mailing list