[LinuxBIOS] r2582 - in trunk/LinuxBIOSv2/src/superio: . fintek fintek/f71805f

Uwe Hermann uwe at hermann-uwe.de
Wed Apr 11 22:20:51 CEST 2007

On Thu, Apr 05, 2007 at 09:52:57PM +0200, Peter Stuge wrote:
> On Thu, Apr 05, 2007 at 08:48:21PM +0200, svn at openbios.org wrote:
> > Author: uwe
> [..]
> > Signed-off-by: Corey Osgood <corey_osgood at verizon.net>
> > Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
> Sorry to bring this up again, but wasn't Uwe supposed to sign off if
> he commits? And a commiter's sign-off is equivalent to an ack?
> I never understood the result of the discussion for this case.
> (How to sign off/ack when also commiting a patch.)

I don't think we had a clear resolution when we last discussed this.

IMHO this procedure is ok:

 - Only add a Signed-off-by if you modified the code. If you're just
   committing someone else's code unmodified, you don't sign-off (but the
   patch creator must have signed-off of course; patches without sign-offs
   must never be committed).

 - Any code which gets committed must have at least one Signed-off-by
   _and_ at least one Acked-by. Thus, if you commit other people's code
   unmodified you add your Ack (if and only if you think the code looks
   good, of course).

We should really document the exact details in the wiki, though...

http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20070411/0eddb9e9/attachment.sig>

More information about the coreboot mailing list