[LinuxBIOS] changes in decompress coming.
Ronald G Minnich
rminnich at lanl.gov
Fri Sep 15 17:46:09 CEST 2006
Richard Smith wrote:
> I really don't like how vague our config options are. I am IMed by
> people all the time asking me what config option such and such does.
> I have to go grep through the code to figure it all out since I can't
> keep them straight myself.
if you're grepping code you're in the wrong place. The
src/config/Options.lb REQUIRES a comment describing the option. There
are 150 options -- there are 1700+ in linux.
I am attaching the result of
egrep define|comment src/config/options.lb to this message. What should
we be doing better? I'm open to any ideas. Some of those comments are
quite good, e.g.
comment "Enable SERIAL POST codes"
Although the definition needs some work ...
but this one:
comment "Set to deal with memory hole"
wins the WTF prize, I suppose.
Unless we count this:
comment "Default image size"
comment "Default rom section size"
eh? What's a section? I think ranchers measure land in sections ...
I think it's the lousy config interface. If we had something like
kconfig, and a <help> button, and (in some cases) better comments, I
think it would be better.
Another really bad aspect is the various names of sizes of things that
few people get, namely:
This stuff, in my view, sucks. I mean, ROM_IMAGE_SIZE? :-)
Here's one that ought to die:
comment "Log messages to SROM console"
That's for the DEC Alpha!
I intend to fix the compression setting checks so it happens at config
time. Beat on me if I don't do it soon.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
More information about the coreboot