[LinuxBIOS] indent

Segher Boessenkool segher at kernel.crashing.org
Sun Oct 8 16:24:10 CEST 2006


>> If you want to run indent at all, do it _once_ (with all the right
>> options!  See lindent) and fix up the fallout later, whenever you
>> stumble on it -- that's the least-effort way to go about it.
>
> some of our specialists send in patches that consist of 50% whitespace
> changes because they are using broken editors that convert tab to  
> space.
>
> question is how to cope with that, especially if those people have
> commit rights themselfes and dont wait for a review to happen.

pre-commit hook, run a regexp that finds the more standard problems,
refuse if bad.

The Linux kernel source code has some such regexp's for you.

But do you really want to completely lock out "bad-looking"
whitespace changes?

You can't solve social problems using technology; you'll have to
change people's habits instead.  *Every* patch should be sent to
the mailing list for review, it doesn't matter who you are.


Segher





More information about the coreboot mailing list