[LinuxBIOS] indent

Uwe Hermann uwe at hermann-uwe.de
Sat Oct 7 23:31:11 CEST 2006


On Fri, Oct 06, 2006 at 12:29:46PM -0600, Ronald G Minnich wrote:
>   I like it but what on earth is indent breaking? I don't like the idea 
> of special comments. What's going on?

One example I noticed:

-       dev = pci_locate_device_on_bus(
-               bus);
+       dev =
+           pci_locate_device_on_bus(PCI_ID
+                                    (PCI_VENDOR_ID_AMD,
+                                     PCI_DEVICE_ID_AMD_8111_ISA), bus);

As PCI_ID is a macro breaking it overmultiple lines seems to cause
trouble (in this case at least).

Uwe Hermann 
http://www.it-services-uh.de  | http://www.crazy-hacks.org 
http://www.holsham-traders.de | http://www.unmaintained-free-software.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20061007/1bc22f45/attachment.sig>

More information about the coreboot mailing list