[LinuxBIOS] [PATCH] Add missing includes to ITE Super I/Os.

[Uwe Hermann]

Add missing #includes to some ITE Super I/O files.

Signed-off-by: Jon Dufresne <jon.dufresne at gmail.com>
Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>

---

On Sun, Nov 26, 2006 at 02:24:00PM -0500, Jon Dufresne wrote:
> Using the available superio I have seen early serial output with an
> ite it8712f chip.

OK, great!


> I have attached a diff fixing all ite includes. Do you normally prefer
> an attachment or that I paste the diff in the email?

I personally don't care. For non-trivial patches we should definately use
the issue tracker, though (http://tracker.linuxbios.org/trac/LinuxBIOS/).


> You mentioned
> adding includes to chip.h, however this file did not need
> modifications for me and after looking at it, I don't think it needs
> additional includes for the code contained in it.

I think it should have an #include for 'struct chip_operations', and I
also added an #include for 'device_t' in *_early_*.c.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
-------------- next part --------------
Index: src/superio/ite/it8712f/it8712f_early_serial.c
===================================================================
--- src/superio/ite/it8712f/it8712f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8712f/it8712f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8712f.h"
 
 /* The base address is 0x2e or 0x4e, depending on config bytes. */
Index: src/superio/ite/it8712f/superio.c
===================================================================
--- src/superio/ite/it8712f/superio.c	(Revision 2510)
+++ src/superio/ite/it8712f/superio.c	(Arbeitskopie)
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include <pc80/keyboard.h>
 #include "chip.h"
Index: src/superio/ite/it8712f/chip.h
===================================================================
--- src/superio/ite/it8712f/chip.h	(Revision 2510)
+++ src/superio/ite/it8712f/chip.h	(Arbeitskopie)
@@ -21,6 +21,7 @@
 #ifndef _SUPERIO_ITE_IT8712F
 #define _SUPERIO_ITE_IT8712F
 
+#include <device/device.h>
 #include <pc80/keyboard.h>
 #include <uart8250.h>
 
Index: src/superio/ite/it8705f/it8705f_early_serial.c
===================================================================
--- src/superio/ite/it8705f/it8705f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8705f/it8705f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8705f.h"
 
 /* The base address is 0x2e or 0x4e, depending on config bytes. */
Index: src/superio/ite/it8705f/superio.c
===================================================================
--- src/superio/ite/it8705f/superio.c	(Revision 2510)
+++ src/superio/ite/it8705f/superio.c	(Arbeitskopie)
@@ -20,6 +20,8 @@
 
 /* This chip doesn't seem to have keyboard and mouse support. */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include "chip.h"
 #include "it8705f.h"
Index: src/superio/ite/it8705f/chip.h
===================================================================
--- src/superio/ite/it8705f/chip.h	(Revision 2510)
+++ src/superio/ite/it8705f/chip.h	(Arbeitskopie)
@@ -23,6 +23,7 @@
 
 /* This chip doesn't seem to have keyboard and mouse support. */
 
+#include <device/device.h>
 #include <uart8250.h>
 
 extern struct chip_operations superio_ite_it8705f_ops;
Index: src/superio/ite/it8661f/it8661f_early_serial.c
===================================================================
--- src/superio/ite/it8661f/it8661f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8661f/it8661f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8661f.h"
 
 /* The base address is 0x3f0, 0x3bd, or 0x370, depending on config bytes. */
Index: src/superio/ite/it8661f/superio.c
===================================================================
--- src/superio/ite/it8661f/superio.c	(Revision 2510)
+++ src/superio/ite/it8661f/superio.c	(Arbeitskopie)
@@ -20,8 +20,9 @@
 
 /* This chip doesn't seem to have keyboard and mouse support. */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
-/* #include <pc80/keyboard.h> */
 #include "chip.h"
 #include "it8661f.h"
 
Index: src/superio/ite/it8661f/chip.h
===================================================================
--- src/superio/ite/it8661f/chip.h	(Revision 2510)
+++ src/superio/ite/it8661f/chip.h	(Arbeitskopie)
@@ -23,6 +23,7 @@
 
 /* This chip doesn't seem to have keyboard and mouse support. */
 
+#include <device/device.h>
 #include <uart8250.h>
 
 extern struct chip_operations superio_ite_it8661f_ops;
Index: src/superio/ite/it8671f/it8671f_early_serial.c
===================================================================
--- src/superio/ite/it8671f/it8671f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8671f/it8671f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8671f.h"
 
 /* The base address is 0x3f0, 0x3bd, or 0x370, depending on config bytes. */
Index: src/superio/ite/it8671f/superio.c
===================================================================
--- src/superio/ite/it8671f/superio.c	(Revision 2510)
+++ src/superio/ite/it8671f/superio.c	(Arbeitskopie)
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include <pc80/keyboard.h>
 #include "chip.h"
Index: src/superio/ite/it8671f/chip.h
===================================================================
--- src/superio/ite/it8671f/chip.h	(Revision 2510)
+++ src/superio/ite/it8671f/chip.h	(Arbeitskopie)
@@ -21,6 +21,7 @@
 #ifndef _SUPERIO_ITE_IT8671F
 #define _SUPERIO_ITE_IT8671F
 
+#include <device/device.h>
 #include <pc80/keyboard.h>
 #include <uart8250.h>
 
Index: src/superio/ite/it8716f/it8716f_early_serial.c
===================================================================
--- src/superio/ite/it8716f/it8716f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8716f/it8716f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8716f.h"
 
 /* The base address is 0x2e or 0x4e, depending on config bytes. */
Index: src/superio/ite/it8716f/superio.c
===================================================================
--- src/superio/ite/it8716f/superio.c	(Revision 2510)
+++ src/superio/ite/it8716f/superio.c	(Arbeitskopie)
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include <pc80/keyboard.h>
 #include "chip.h"
Index: src/superio/ite/it8716f/chip.h
===================================================================
--- src/superio/ite/it8716f/chip.h	(Revision 2510)
+++ src/superio/ite/it8716f/chip.h	(Arbeitskopie)
@@ -21,6 +21,7 @@
 #ifndef _SUPERIO_ITE_IT8716F
 #define _SUPERIO_ITE_IT8716F
 
+#include <device/device.h>
 #include <pc80/keyboard.h>
 #include <uart8250.h>
 
Index: src/superio/ite/it8673f/it8673f_early_serial.c
===================================================================
--- src/superio/ite/it8673f/it8673f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8673f/it8673f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8673f.h"
 
 /* The base address is 0x3f0, 0x3bd, or 0x370, depending on config bytes. */
Index: src/superio/ite/it8673f/superio.c
===================================================================
--- src/superio/ite/it8673f/superio.c	(Revision 2510)
+++ src/superio/ite/it8673f/superio.c	(Arbeitskopie)
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include <pc80/keyboard.h>
 #include "chip.h"
Index: src/superio/ite/it8673f/chip.h
===================================================================
--- src/superio/ite/it8673f/chip.h	(Revision 2510)
+++ src/superio/ite/it8673f/chip.h	(Arbeitskopie)
@@ -21,6 +21,7 @@
 #ifndef _SUPERIO_ITE_IT8673F
 #define _SUPERIO_ITE_IT8673F
 
+#include <device/device.h>
 #include <pc80/keyboard.h>
 #include <uart8250.h>
 
Index: src/superio/ite/it8718f/it8718f_early_serial.c
===================================================================
--- src/superio/ite/it8718f/it8718f_early_serial.c	(Revision 2510)
+++ src/superio/ite/it8718f/it8718f_early_serial.c	(Arbeitskopie)
@@ -19,6 +19,7 @@
  */
 
 #include <arch/romcc_io.h>
+#include <device/device.h>
 #include "it8718f.h"
 
 /* The base address is 0x2e or 0x4e, depending on config bytes. */
Index: src/superio/ite/it8718f/superio.c
===================================================================
--- src/superio/ite/it8718f/superio.c	(Revision 2510)
+++ src/superio/ite/it8718f/superio.c	(Arbeitskopie)
@@ -18,6 +18,8 @@
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+#include <device/device.h>
+#include <device/pnp.h>
 #include <uart8250.h>
 #include <pc80/keyboard.h>
 #include "chip.h"
Index: src/superio/ite/it8718f/chip.h
===================================================================
--- src/superio/ite/it8718f/chip.h	(Revision 2510)
+++ src/superio/ite/it8718f/chip.h	(Arbeitskopie)
@@ -21,6 +21,7 @@
 #ifndef _SUPERIO_ITE_IT8718F
 #define _SUPERIO_ITE_IT8718F
 
+#include <device/device.h>
 #include <pc80/keyboard.h>
 #include <uart8250.h>
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20061129/48de4864/attachment.sig>