[LinuxBIOS] #33: Signed-off-by in trac is meaningless

Segher Boessenkool segher at kernel.crashing.org
Sun Nov 5 22:32:59 CET 2006


> #33: Signed-off-by in trac is meaningless

>  Signed-off-by: and Acked-by: always corresponds to the latest  
> added patch,
>  unless otherwise noted. Since each patch and each comment has a  
> timestamp,
>  everything is clear, right?

IU&^*^*(^(*^*(^*(^(*&!!!!!!!!!!!!!!

Internal Error
Sorry, can not save your changes. This ticket has been modified by  
someone else since you started

TracGuide — The Trac User and Administration Guide

---

Well I'll paste my comment here then.  Here goes:

---

 > Signed-off-by: and Acked-by: always corresponds to the latest  
added patch, unless otherwise noted. Since each patch and each  
comment has a timestamp, everything is clear, right?

So two patches by Uwe on a ticket with 3 comments -- yeah sure
we can handle that.  Now how about a ticket with 12 proposed
patches by 4 people, each fixing part of the problem, some superseded
by newer patches; and all of that intermingled with some odd 100
comments?  Can you still align that so that you clearly see or supposed
"paper" track of origin of the code?


Maybe this is all just a symptom of a greater problem: patches should
always be presented with a proposed check-in comment, and the
signed-off-by should be part of that comment.


Segher





More information about the coreboot mailing list