[LinuxBIOS] selection of compression algorithm

[Per Hallsmark]

well, perhaps not so weird... the #ifdef 0 is weird. Shouldn't it be #if 
0 instead to comment out stuff? :-)

Stefan Reinauer wrote:

>* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [060524 02:06]:
>  
>
>>Stefan Reinauer wrote:
>>    
>>
>>>* Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net> [060523 20:09]:
>>>      
>>>
>>>>Ronald G Minnich wrote:
>>>>        
>>>>
>>>>>Carl-Daniel Hailfinger wrote:
>>>>>
>>>>>          
>>>>>
>>>>>>I have no platform on which LinuxBIOS runs on, but it caused no
>>>>>>regression
>>>>>>in abuild. (But a lot of targets do not seem to compile at all, even
>>>>>>without
>>>>>>my patch. Does this depend on the gcc version? I have gcc 3.3.5)
>>>>>>            
>>>>>>
>>>>>don't know, I will try to test your patch via abuild but I don't want to
>>>>>commit until then.
>>>>>          
>>>>>
>>>>Yes, it was a gcc bug. gcc 4.1.0 has no problems compiling it.
>>>>I'll continue testing and developing with gcc 4.1.0 from now on.
>>>>        
>>>>
>>>Can we get it compiling with 3.3.5 as well? What's the bug about?
>>>I'm using 4.1 as a reference compiler at the moment, but lots of people
>>>out there have older compilers I think...
>>>      
>>>
>>LinuxBIOSv2-2310/src/cpu/amd/model_gx2/cpubug.c:199:75: missing terminating ' character
>>LinuxBIOSv2-2310/src/cpu/amd/model_gx2/cpubug.c:205:70: missing terminating ' character
>>    
>>
>
>Indeed weird! This is in the middle of #ifdef 0?
>
>
>  
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20060524/a71888cb/attachment.html>