[LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

Segher Boessenkool segher at kernel.crashing.org
Wed Dec 6 16:31:36 CET 2006


>> What do you mean by
>> +	for (reps = 0; reps >= 0; reps++) {
>> ?
>
> If you will not reps is negative.  Roughly it is a loop
> that will timeout eventually if a usb debug cable is not present.

> So since I didn't know how many loop iterations made sense I allowed
> it to loop for 2^31 times or until reps goes negative.

This doesn't work however.  Signed overflow in C is undefined,
and GCC actually optimises accordingly (unless -fwrapv is used).


Segher





More information about the coreboot mailing list