[LinuxBIOS] LNXI Merge: lnxi-patch-15/16

Eric W. Biederman ebiederman at lnxi.com
Wed Sep 7 17:41:53 CEST 2005

yhlu <yinghailu at gmail.com> writes:

> I agree.
> The cache_as_ram_auto.c should be the same to all Opteron MB except for
> 1 spd rom related.
> 2 superio related
> Other thing is need to consider apic id lifting.
> So i consider change that to
> #include "auto_1.c"
> int someting spd and superio related
> #include "auto_2.c"

Boards can get weird and wonderful when their designers are creative.
So I would like to keep this as a matter of common subroutines we
can call, rather than magic includes.  The practical difference is
minimal, but common subroutines are much more readable.


More information about the coreboot mailing list