[LinuxBIOS] LNXI Merge: lnxi-patch-06/16
Hamish Guthrie
hamish at prodigi.ch
Sat Sep 3 18:43:15 CEST 2005
This patch is CRAP!!!!
This unconditionally breaks tsc usage for single-processor systems.
PLEASE leave the original code as it was - it is generic code for both
SMP and uni-processor environments. The code as it is does not break
your SMP code, so why break our uni-processor code?????
Thanks
Hamish
jason schildt wrote:
> DESCRIPTION:
> ----------------------------------------------
>
> ## lnxi-patch-6 ##
> src/cpu/x86/tsc/delay_tsc.c
> cpu_relax() gets called unconditionally.
>
>
> DIFFSTAT:
> ----------------------------------------------
> delay_tsc.c | 4 ----
> 1 files changed, 4 deletions(-)
>
>
>
> PATCH:
> ----------------------------------------------
>
> Index: delay_tsc.c
> ===================================================================
> --- delay_tsc.c (revision 1105)
> +++ delay_tsc.c (working copy)
> @@ -159,11 +159,7 @@
> count = rdtscll();
> stop = clocks + count;
> while(stop > count) {
> -#ifdef CONFIG_SMP
> -#if CONFIG_SMP == 1
> cpu_relax();
> -#endif
> -#endif
> count = rdtscll();
> }
> }
>
> --
>
> Jason W. Schildt
> LinuxBIOS Software Engineer
> Linux Networx
>
More information about the coreboot
mailing list