[LinuxBIOS] Proposed change to amd/amdk8/incoherent_ht.c

Eric W. Biederman ebiederman at lnxi.com
Wed Oct 26 19:05:15 CEST 2005


San Mehat <san at google.com> writes:

> While we're on the 'error handling' track, I also had an issue where
> 'ht_optimize_link()' was continually indicating that a reset was required and
> causing an endless reset loop. The culprit was the code which performs an 8 bit
> read to get the *current* frequency of the link and doesn't mask off the error
> bits next to the frequency bits (bits 0-4 are frequency, and bits 5-7 are error
> status).
>
> Once again, this was triggered by a transient error on the link (likely due to
> link retraining).

Thanks.  We just committed an equivalent version. :)

Eric




More information about the coreboot mailing list