Running with VGA
Li-Ta Lo
ollie at lanl.gov
Wed Jan 12 15:17:01 CET 2005
On Wed, 2005-01-12 at 18:42, YhLu wrote:
> I add driver/pci/onboard, it will take rom_address in conf.
>
> Also add some line in pci_rom.c
> /* for the onboard vga it already got one VGA rom space ? bug
> it should be allocated and just use the assigned value
> */
>
> if(dev->on_mainboard) {
> struct drivers_pci_onboard_config *conf;
> conf = dev->chip_info;
> if(conf->rom_address!=0) {
> rom_address = conf->rom_address;
> }
> }
>
>
> Can you move that to pci_device.c ( allocate rom address)?
>
> I mean if it is on board, and have rom_address in Config.lb, it should use
> that instead of allocate one for it.
>
If you put these piece of code in pci_device.c then we have to include
device specific chip.h in the generic pci_device.c. Are you sure we
should do that?
Ollie
More information about the coreboot
mailing list