coherent_ht.c,1.29,1.30

Eric W. Biederman ebiederman at lnxi.com
Mon Nov 15 10:37:01 CET 2004


Stefan Reinauer <stepan at openbios.org> writes:

> * Eric W. Biederman <ebiederman at lnxi.com> [041115 17:42]:
> > However there are 2 significant checks we can perform.
> > - Did the original version compile?
> > - Does this work on the tyan/s2850
> 
> does the s2850 use an athlon64? Iirc the problem was that the athlon64
> has less ht links..

I am pretty certain that case was limited to the code that was
living in misc_control.c.  For which this problem has been resolved.

> > So unless YhLu has problems on the s2850 or we can dig something up in
> > the mailing list archives I am fairly certain that this change is ok.
>  
> The best way to test this is testing on a solo system.. If somebody has
> one... Which I dont. Otherwise I suggest we mark the solo build broken
> until someone can verify this..

Actually looking at this the code is exactly what we have in misc_control.c
Which has been tested on an Athlon64 so I'm not concerned.

Eric



More information about the coreboot mailing list