Removing device driver code in mainboard.c for Tyan boards?

Eric W. Biederman ebiederman at
Fri Nov 5 18:49:01 CET 2004

YhLu <YhLu at> writes:

> I changed e7501 to use root_complex too.

Could we please reserve this construct for chipsets
with multiple northbridges?

I think it is just going to be extra noise on a
simple chipset like the e7501.

And since the e7501 is an example to a certain extent having it
doing extra work be confusing and a pain.

> If the chip_ops has no .name, then should use
> 	config chip.h 
> end
> also .c include that chip_ops
> ...chip_ops defininition
> #endif
> Regards
> Such as norththbridge, socket, mainboard(root).

They can.  But I am about to suggest simply removing the config
directive, and assuming the ``config chip.h'' is always given.  The
overhead is almost zero for a zero filled structure.  And always
requiring a chip.h would tend to simply the process of writing code
for a new chip.


More information about the coreboot mailing list