Merge/Cleanup status

Eric W. Biederman ebiederman at lnxi.com
Tue Nov 2 05:26:00 CET 2004


"Yinghai Lu" <yhlu at tyan.com> writes:

> Eric,
> 
> What the reasons that you set MTRRs for one CPU two times.?
> amd_setup_mtrrs of amd_mtrr.c call x86_setup_mtrrs...

This is just the fixed mtrrs.  The code should be refined further,
but this code properly sets the RD_MEM and WR_MEM bits in the fixed
mtrrs.

Given how the code is currently factored this was the easiest way to
code it cleanly.  I expect to revisit this when looking at overlapping mtrr
support. 

Eric



More information about the coreboot mailing list