答复: Cache On and ECC clear

[YhLu]

After exchange cpufixup after cache_on, 

In s2885, it can clear the memory quite faster. 

YH.

-----邮件原件-----
发件人: Li-Ta Lo [mailto:ollie at lanl.gov] 
发送时间: 2004年3月26日 8:55
收件人: Eric W. Biederman
抄送: LinuxBIOS
主题: Re: Cache On and ECC clear

On Fri, 2004-03-26 at 01:06, Eric W. Biederman wrote:
> Li-Ta Lo <ollie at lanl.gov> writes:
> 
> > Eric,
> > 
> > I tried to call cache_on() first than the cpufixeup()
> > in cpu.c to fix the "slow ecc clear" problem. It still
> > works that way. Is there any reason we can't do this ?
> 
> Hmm.  I don't see this.  I have the cache on and things
> clear quite quickly.  I may have a slightly different calling
> order then the standard tree.  
> 
> Ollie can you compare what is checked into the tree with 
> the last release I did for Lightning?  It works there...
> 

In LNXI tree it's like:

        /* Turn on caching if we haven't already */
        cache_on(mem);
 

        display_cpuid();
        mtrr_check();
#if 1
        /* some cpus need a fixup done. This is the hook for doing that.
*/
        cpufixup(mem);
#endif

and in the CVS tree it's:

	/* some cpus need a fixup done. This is the hook for doing that. */
	cpufixup(mem);

	/* Turn on caching if we haven't already */
	cache_on(mem);

	display_cpuid();
	mtrr_check();

Ollie


_______________________________________________
Linuxbios mailing list
Linuxbios at clustermatic.org
http://www.clustermatic.org/mailman/listinfo/linuxbios