coding

Robert Walsh rjwalsh at durables.org
Tue Sep 2 15:38:01 CEST 2003


> enum {
>  FLOPPY_DEVICE=0,
>  PARALLEL_DEVICE,
>  COM2_DEVICE,    
>  COM1_DEVICE,    
>  SWC_DEVICE,     
>  MOUSE_DEVICE,   
>  KBC_DEVICE,     
>  GPIO_DEVICE,    
>  ACB_DEVICE,     
>  FSCM_DEVICE,    
>  WDT_DEVICE
> };

If you're going to stick with an enum, why not put a comma after the
last entry, so diffs look cleaner later on:

enum {
 FLOPPY_DEVICE=0,
 PARALLEL_DEVICE,
 COM2_DEVICE,    
 COM1_DEVICE,    
 SWC_DEVICE,     
 MOUSE_DEVICE,   
 KBC_DEVICE,     
 GPIO_DEVICE,    
 ACB_DEVICE,     
 FSCM_DEVICE,    
 WDT_DEVICE,
};

Regards,
 Robert.




More information about the coreboot mailing list