[coreboot-gerrit] Change in coreboot[master]: soc/intel/.../hda: Add and use config for initialization of HDA codecs

Furquan Shaikh (Code Review) gerrit at coreboot.org
Sun Sep 30 08:57:07 CEST 2018


Hello build bot (Jenkins), 

I'd like you to reexamine a change. Please visit

    https://review.coreboot.org/28806

to look at the new patch set (#2).

Change subject: soc/intel/.../hda: Add and use config for initialization of HDA codecs
......................................................................

soc/intel/.../hda: Add and use config for initialization of HDA codecs

Config option SOC_INTEL_COMMON_BLOCK_HDA is currently used for
initialization of HDA codecs only. This prevents adding of any static
devices under the HDA device node. However, there can be boards which
want to add devices under HDA node without performing any codec
initialization using the HDA. This change:
1. Adds a new config option SOC_INTEL_COMMON_BLOCK_HDA_VERB that can
be set explicitly by the boards that want to perform codec
initialization.
2. Uses newly added config option is used to guard the initialization
functions for the codec. Rest of the device operations can still be
used by all the other boards without having to use HDA codec
initialization.
3. Selects the newly added option SOC_INTEL_COMMON_BLOCK_HDA_VERB in
kblrvp which was the only board enabling HDA codec initialization
using common block code.
4. Selects original config SOC_INTEL_COMMON_BLOCK_HDA for skylake SoC.

Above changes need to be bundled and pushed in as a single change in
order to avoid breaking existing users.

BUG=b:112888584

Change-Id: Ie6f39c13a801833b283120a2d4b6f6175688999c
Signed-off-by: Furquan Shaikh <furquan at google.com>
---
M src/mainboard/intel/kblrvp/Kconfig
M src/soc/intel/common/block/hda/Kconfig
M src/soc/intel/common/block/hda/hda.c
M src/soc/intel/skylake/Kconfig
4 files changed, 12 insertions(+), 1 deletion(-)


  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/28806/2
-- 
To view, visit https://review.coreboot.org/28806
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie6f39c13a801833b283120a2d4b6f6175688999c
Gerrit-Change-Number: 28806
Gerrit-PatchSet: 2
Gerrit-Owner: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180930/ace531a3/attachment.html>


More information about the coreboot-gerrit mailing list