[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: increase touchscreen reset delay

Nick Vaccaro (Code Review) gerrit at coreboot.org
Sun Sep 30 00:07:57 CEST 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/28803


Change subject: mb/google/poppy/variant/nocturne: increase touchscreen reset delay
......................................................................

mb/google/poppy/variant/nocturne: increase touchscreen reset delay

Increase the reset delay for the touchscreen to 10 seconds.

BUG=b:116857433
TEST='emerge-nocturne coreboot chromeos-bootimage', flash and boot
nocturne to kernel, log in and execute the following two commands:
  echo "i2c-WCOM50C1:00" > /sys/bus/i2c/drivers/i2c_hid/unbind
  echo "i2c-WCOM50C1:00" > /sys/bus/i2c/drivers/i2c_hid/bind
and verify the bind command does not echo back a
"-bash: echo: write error: No such device" error.

Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/28803/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
index 70a379c..c6a18f7 100644
--- a/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nocturne/devicetree.cb
@@ -291,7 +291,7 @@
 				register "generic.speed" = "I2C_SPEED_FAST_PLUS"
                                 register "generic.probed" = "1"
                                 register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_E11)"
-                                register "generic.reset_delay_ms" = "1"
+                                register "generic.reset_delay_ms" = "10"
                                 register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"
                                 register "generic.enable_delay_ms" = "1"
                                 register "generic.has_power_resource" = "1"

-- 
To view, visit https://review.coreboot.org/28803
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I102b57ea5a10d22bee6d4f7c6f114b380a5d586b
Gerrit-Change-Number: 28803
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180929/18afebda/attachment.html>


More information about the coreboot-gerrit mailing list