[coreboot-gerrit] Change in coreboot[master]: drivers/spi/winbond: Add function to lock flash's status register

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )

Change subject: drivers/spi/winbond: Add function to lock flash's status register
......................................................................


Patch Set 5:

(8 comments)

https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:

https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@540
PS5, Line 540: 		        const enum spi_flash_status_reg_lockdown mode,
code indent should use tabs where possible


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@541
PS5, Line 541: 		        const bool non_volatile)
code indent should use tabs where possible


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@555
PS5, Line 555: 		val = (union status_reg1_bp3){ .srp0 = !!(mode & 1) }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@556
PS5, Line 556: 		mask = (union status_reg1_bp3){ .srp0 = 1 }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@558
PS5, Line 558: 		val = (union status_reg1_bp4){ .srp0 = !!(mode & 1) }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@559
PS5, Line 559: 		mask = (union status_reg1_bp4){ .srp0 = 1 }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@566
PS5, Line 566: 	val = (union status_reg2){ .srp1 = !!(mode & 2) }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/28697/5/src/drivers/spi/winbond.c@567
PS5, Line 567: 	mask = (union status_reg2){ .srp1 = 1 }.u;
space required after that close brace '}'



-- 
To view, visit https://review.coreboot.org/28697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0fcdcf531b53c0fc1ffcfdb3b5ab522f088f5
Gerrit-Change-Number: 28697
Gerrit-PatchSet: 5
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 28 Sep 2018 10:59:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180928/bc264b31/attachment.html>