[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Load AOAC and USB gnvs values

[Richard Spiegel (Code Review)]

Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/28767 )

Change subject: amd/stoneyridge: Load AOAC and USB gnvs values
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c
File src/soc/amd/stoneyridge/southbridge.c:

https://review.coreboot.org/#/c/28767/1/src/soc/amd/stoneyridge/southbridge.c@914
PS1, Line 914: 1;
> No, not certain.  This will eventually be used for SD.  I'll update the source.
Search for "AOACx[7F:41:step2] Device D3 State" in the NDA BKDG (probably also available in the public one), and you'll understand the values of 0x5F, 0x71 and 0x77. The even offsets is for D3 control, the odd ones for D3 state. And yes, procedure is_aoac_device_enabled() was created to use specifically these offsets when checking if a device is enabled (D0) or disabled (D3).



-- 
To view, visit https://review.coreboot.org/28767
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8af69c030eb2353ad75beeb2bfd3bef24abff04c
Gerrit-Change-Number: 28767
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 21:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/8619ef07/attachment.html>