[coreboot-gerrit] Change in coreboot[master]: amd/stoneyridge: Add USB settings to gnvs

Martin Roth (Code Review) gerrit at coreboot.org
Thu Sep 27 22:11:28 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/28766 )

Change subject: amd/stoneyridge: Add USB settings to gnvs
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28766/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl
File src/soc/amd/stoneyridge/acpi/globalnvs.asl:

https://review.coreboot.org/#/c/28766/1/src/soc/amd/stoneyridge/acpi/globalnvs.asl@68
PS1, Line 68: FW00,	16,
If we dword align the above structure, we might group the 2 16-bit fields to keep the others dword aligned as well.



-- 
To view, visit https://review.coreboot.org/28766
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32205ac8a6908cca4a38dd68a7c7b591e76c06bb
Gerrit-Change-Number: 28766
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 27 Sep 2018 20:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180927/38c8652f/attachment.html>


More information about the coreboot-gerrit mailing list