[coreboot-gerrit] Change in coreboot[master]: payloads/Kconfig: do not show compression menu for FIT
Patrick Georgi (Code Review)
gerrit at coreboot.org
Wed Sep 26 17:39:02 CEST 2018
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28732 )
Change subject: payloads/Kconfig: do not show compression menu for FIT
......................................................................
payloads/Kconfig: do not show compression menu for FIT
FIT payloads do not support compression. Currently this would thrown an error
like the following:
E: FIT images don't support whole-image compression, compress the kernel component instead!
With this patch, menuconfig will correctly *not* show payload compression for
FIT payloads, and this will correctly set compression to NONE.
Change-Id: If564e2f5c0d499bc30411d7bd41611790453d4ef
Signed-off-by: Andrea Barberio <insomniac at slackware.it>
Reviewed-on: https://review.coreboot.org/28732
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Patrick Rudolph <siro at das-labor.org>
---
M payloads/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Patrick Rudolph: Looks good to me, approved
diff --git a/payloads/Kconfig b/payloads/Kconfig
index 5e76ebe..8e05df3 100644
--- a/payloads/Kconfig
+++ b/payloads/Kconfig
@@ -64,7 +64,7 @@
choice
prompt "Payload compression algorithm"
default COMPRESSED_PAYLOAD_LZMA
- depends on !PAYLOAD_NONE && !PAYLOAD_LINUX && !PAYLOAD_LINUXBOOT
+ depends on !PAYLOAD_NONE && !PAYLOAD_LINUX && !PAYLOAD_LINUXBOOT && !PAYLOAD_FIT
help
Choose the compression algorithm for the chosen payloads.
You can choose between LZMA and LZ4.
--
To view, visit https://review.coreboot.org/28732
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If564e2f5c0d499bc30411d7bd41611790453d4ef
Gerrit-Change-Number: 28732
Gerrit-PatchSet: 2
Gerrit-Owner: Andrea Barberio <insomniac at slackware.it>
Gerrit-Reviewer: Andrea Barberio <insomniac at slackware.it>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: Philipp Deppenwiese <zaolin.daisuki at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/92fc75fa/attachment.html>
More information about the coreboot-gerrit
mailing list