[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block: Don't use device_t

Patrick Georgi (Code Review) gerrit at coreboot.org
Wed Sep 26 17:16:14 CEST 2018


Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/28694 )

Change subject: soc/intel/common/block: Don't use device_t
......................................................................

soc/intel/common/block: Don't use device_t

Use of device_t is deprecated.

Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/28694
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/soc/intel/common/block/include/intelblocks/smihandler.h
M src/soc/intel/common/block/smm/smihandler.c
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jonathan Neuschäfer: Looks good to me, approved



diff --git a/src/soc/intel/common/block/include/intelblocks/smihandler.h b/src/soc/intel/common/block/include/intelblocks/smihandler.h
index 197268b..050d93a 100644
--- a/src/soc/intel/common/block/include/intelblocks/smihandler.h
+++ b/src/soc/intel/common/block/include/intelblocks/smihandler.h
@@ -155,7 +155,7 @@
  * This function returns a 1 or 0 depending on whether disable_busmaster
  * needs to be done for the specified device on S5 entry
  */
-int smihandler_soc_disable_busmaster(device_t dev);
+int smihandler_soc_disable_busmaster(pci_devfn_t dev);
 
 /* SMI handlers that should be serviced in SCI mode too. */
 uint32_t smihandler_soc_get_sci_mask(void);
diff --git a/src/soc/intel/common/block/smm/smihandler.c b/src/soc/intel/common/block/smm/smihandler.c
index c6f9692..e4c13dd 100644
--- a/src/soc/intel/common/block/smm/smihandler.c
+++ b/src/soc/intel/common/block/smm/smihandler.c
@@ -46,7 +46,7 @@
 	return;
 }
 
-__weak int smihandler_soc_disable_busmaster(device_t dev)
+__weak int smihandler_soc_disable_busmaster(pci_devfn_t dev)
 {
 	return 1;
 }

-- 
To view, visit https://review.coreboot.org/28694
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id82059898844fbe20665250062b67652d6cc1f9e
Gerrit-Change-Number: 28694
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/e1d5e672/attachment.html>


More information about the coreboot-gerrit mailing list