[coreboot-gerrit] Change in coreboot[master]: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"

Martin Roth (Code Review) gerrit at coreboot.org
Wed Sep 26 16:12:20 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28690 )

Change subject: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"
......................................................................

Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"

This reverts commit aef592d9b66aa18d83b0a211ead26013ff1f7d98.

Reason for revert: Use values from driver instead of hardcoding in 
firmware (b:113303916)

Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4
Signed-off-by: Seunghwan Kim <sh_.kim at samsung.com>
Reviewed-on: https://review.coreboot.org/28690
Reviewed-by: Furquan Shaikh <furquan at google.com>
Reviewed-by: Enrico Granata <egranata at chromium.org>
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
---
M src/mainboard/google/poppy/variants/nautilus/devicetree.cb
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved
  Enrico Granata: Looks good to me, but someone else must approve



diff --git a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
index 109d2b6..37edd8a 100644
--- a/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/nautilus/devicetree.cb
@@ -334,13 +334,6 @@
 				register "desc" = ""SAR Proximity Sensor""
 				register "irq" = "ACPI_IRQ_LEVEL_LOW(GPP_A18_IRQ)"
 				register "device_present_gpio" = "GPP_B20"
-				register "property_count" = "2"
-				register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER"
-				register "property_list[0].name" = ""STH9321,reg_prox_ctrl6""
-				register "property_list[0].integer" = "75"
-				register "property_list[1].type" = "ACPI_DP_TYPE_INTEGER"
-				register "property_list[1].name" = ""STH9321,reg_prox_ctrl7""
-				register "property_list[1].integer" = "99"
 				device i2c 28 on end
 			end
 		end # I2C #2

-- 
To view, visit https://review.coreboot.org/28690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4
Gerrit-Change-Number: 28690
Gerrit-PatchSet: 4
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Enrico Granata <egranata at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/2bf11346/attachment.html>


More information about the coreboot-gerrit mailing list