[coreboot-gerrit] Change in coreboot[master]: siemens/mc_apl1: Add new mainboard variant mc_apl2

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/28735 )

Change subject: siemens/mc_apl1: Add new mainboard variant mc_apl2
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/28735/1//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28735/1//COMMIT_MSG@10
PS1, Line 10: contains
> "contains" or "is based on"
Done


https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig
File src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig:

https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/variants/mc_apl2/Kconfig@8
PS1, Line 8: select DRIVER_SIEMENS_NC_F
> We do not need the IO based UART here. […]
Done


https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c
File src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c:

https://review.coreboot.org/#/c/28735/1/src/mainboard/siemens/mc_apl1/variants/mc_apl2/mainboard.c@32
PS1, Line 32: /* Set Master Enable for on-board PCI device. */
            : 	dev = dev_find_device(PCI_VENDO
> This is not needed as well but we can get rid of it in one of the next commits.
You're right. We should go the same way as with the baseboard.



-- 
To view, visit https://review.coreboot.org/28735
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0af60ab0dfe556dd95da2cf1a49c685a8f0ae4eb
Gerrit-Change-Number: 28735
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer at siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh at siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Wed, 26 Sep 2018 12:37:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/1cf3f77b/attachment.html>