[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add ACPI entry for LAN

[Lijian Zhao (Code Review)]

Lijian Zhao has posted comments on this change. ( https://review.coreboot.org/28743 )

Change subject: soc/intel/cannonlake: Add ACPI entry for LAN
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28743/1/src/soc/intel/cannonlake/acpi/pch_glan.asl
File src/soc/intel/cannonlake/acpi/pch_glan.asl:

https://review.coreboot.org/#/c/28743/1/src/soc/intel/cannonlake/acpi/pch_glan.asl@28
PS1, Line 28: Method (_DSW, 3) {
> We shouldn't need this method if it doesn't exist right? […]
Yes _DSW is optional, for SOC point of view, we can leave it here in case any platform special action can be done from mainboard side. Windows device manager will hide/unhide power management tab with or without _PRW. But not too sure about _DSW



-- 
To view, visit https://review.coreboot.org/28743
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15bf1d4065894531871380b3318f553b637f4a97
Gerrit-Change-Number: 28743
Gerrit-PatchSet: 1
Gerrit-Owner: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Lijian Zhao <lijian.zhao at intel.com>
Gerrit-Comment-Date: Wed, 26 Sep 2018 00:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180926/14a45e21/attachment.html>