[coreboot-gerrit] Change in coreboot[master]: drivers/spi: Winbond specific write-protection enable

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 )

Change subject: drivers/spi: Winbond specific write-protection enable
......................................................................


Patch Set 21:

(7 comments)

https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:

https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@33
PS21, Line 33: #define CMD_VOLATILE_SREG_WREN	0x50	/* Write Enable for Volatile Status Register */
line over 80 characters


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@502
PS21, Line 502: 		val = (union status_reg1_bp3){ .bp = bp, .tb = tb, .sec = 0 }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@503
PS21, Line 503: 		mask = (union status_reg1_bp3){ .bp = ~0, .tb = 1, .sec = 1 }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@505
PS21, Line 505: 		val = (union status_reg1_bp4){ .bp = bp, .tb = tb }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@506
PS21, Line 506: 		mask = (union status_reg1_bp4){ .bp = ~0, .tb = 1 }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@513
PS21, Line 513: 	val = (union status_reg2){ .cmp = cmp }.u;
space required after that close brace '}'


https://review.coreboot.org/#/c/25105/21/src/drivers/spi/winbond.c@514
PS21, Line 514: 	mask = (union status_reg2){ .cmp = 1 }.u;
space required after that close brace '}'



-- 
To view, visit https://review.coreboot.org/25105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3765b013855538eca37bc7800d3f9d5d09b8402
Gerrit-Change-Number: 25105
Gerrit-PatchSet: 21
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: David Hendricks <david.hendricks at gmail.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Julius Werner <jwerner at chromium.org>
Gerrit-Comment-Date: Tue, 25 Sep 2018 13:25:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180925/9870a2be/attachment.html>