[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28669 )

Change subject: mb/google/octopus: Close unused I2C bus 7 include SCL and SDA for Phaser
......................................................................


Patch Set 18:

(4 comments)

https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/variants/phaser/variant.c
File src/mainboard/google/octopus/variants/phaser/variant.c:

https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/variants/phaser/variant.c@47
PS18, Line 47: 	/* According to the sku id decide whether update touch screen device information:
line over 80 characters


https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/variants/phaser/variant.c@49
PS18, Line 49: 	 * 2. sku id is other value then dev->enabled = 1. 
trailing whitespace


https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/variants/phaser/variant.c@64
PS18, Line 64: 		/* Find all children on bus to update touchscreen enable gpio. */
line over 80 characters


https://review.coreboot.org/#/c/28669/18/src/mainboard/google/octopus/variants/phaser/variant.c@65
PS18, Line 65: 		while ((child = dev_bus_each_child(children_bus, child)) != NULL) {
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28669
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8ad17761f2a053dc329bbec0a0a3284d47289666
Gerrit-Change-Number: 28669
Gerrit-PatchSet: 18
Gerrit-Owner: Peichao Li <peichao.wang at bitland.corp-partner.google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jett Rink <jettrink at google.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Peichao Li <peichao.wang at bitland.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 25 Sep 2018 01:16:54 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180925/82a43f74/attachment.html>