[coreboot-gerrit] Change in coreboot[master]: soc/intel/basecode: Add support for updating ucode loaded via FIT

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27369 )

Change subject: soc/intel/basecode: Add support for updating ucode loaded via FIT
......................................................................


Patch Set 20:

(3 comments)

https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_update/ucode_update.c
File src/soc/intel/common/basecode/fw_update/ucode_update.c:

https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_update/ucode_update.c@157
PS20, Line 157: 	printk(BIOS_INFO, "UCODE: Current ucode version: 0x%x\n", current_ucode);
line over 80 characters


https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_update/ucode_update.c@197
PS20, Line 197: 	} else {
else is not generally useful after a break or return


https://review.coreboot.org/#/c/27369/20/src/soc/intel/common/basecode/fw_update/ucode_update.c@198
PS20, Line 198: 		/* Update successfull */
'successfull' may be misspelled - perhaps 'successful'?



-- 
To view, visit https://review.coreboot.org/27369
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6ba36a2eb587f331fe522c778e2c430c8eb655
Gerrit-Change-Number: 27369
Gerrit-PatchSet: 20
Gerrit-Owner: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi at intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik at intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-CC: Dhaval Sharma <dhaval.v.sharma at intel.corp-partner.google.com>
Gerrit-CC: Patrick Rudolph <siro at das-labor.org>
Gerrit-Comment-Date: Mon, 24 Sep 2018 13:14:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180924/89fc24af/attachment.html>