[coreboot-gerrit] Change in coreboot[master]: vpd: Add support for reading BD addreses from the VPD
Matthias Kaehlcke (Code Review)
gerrit at coreboot.org
Sat Sep 22 01:51:17 CEST 2018
Matthias Kaehlcke has posted comments on this change. ( https://review.coreboot.org/28711 )
Change subject: vpd: Add support for reading BD addreses from the VPD
......................................................................
Patch Set 1:
Yeah, I was also surprised to find it spread over coreboot and depthcharge, took me a bit to figure out how things fit together.
I agree the current mechanism is brittle and it would be preferable to have something more robust in a single place, if depthcharge has a VPD driver this seems feasible. I'll look into it and bother Julius with questions if needed ;-)
--
To view, visit https://review.coreboot.org/28711
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib290fba2504f6ed80c3a95e24627ae5922e608af
Gerrit-Change-Number: 28711
Gerrit-PatchSet: 1
Gerrit-Owner: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: Brian Norris <briannorris at chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: Matthias Kaehlcke <mka at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Sep 2018 23:51:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180921/989c4c46/attachment.html>
More information about the coreboot-gerrit
mailing list