[coreboot-gerrit] Change in coreboot[master]: amd/common/psp: Remove use of PspBaseLib
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Fri Sep 21 19:42:46 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27619 )
Change subject: amd/common/psp: Remove use of PspBaseLib
......................................................................
Patch Set 18:
(2 comments)
https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c
File src/soc/amd/common/block/psp/psp.c:
https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c@70
PS18, Line 70: pci_write_config32(SOC_PSP_DEV, PSP_PCI_EXT_HDR_CTRL, MAGIC_ENABLE_BITS);
line over 80 characters
https://review.coreboot.org/#/c/27619/18/src/soc/amd/common/block/psp/psp.c@92
PS18, Line 92: if (pci_read_config32(SOC_PSP_DEV, PSP_PCI_EXT_HDR_CTRL) & BAR3HIDEBIT) {
line over 80 characters
--
To view, visit https://review.coreboot.org/27619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2740ceb945736c6e413f7d0bd0c41a19e19c7d5a
Gerrit-Change-Number: 27619
Gerrit-PatchSet: 18
Gerrit-Owner: Charles Marslett <charles.marslett at amd.corp-partner.google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Charles Marslett <charles.marslett at amd.corp-partner.google.com>
Gerrit-Reviewer: Charles Marslett <charles.marslett at silverbackltd.com>
Gerrit-Reviewer: Marshall Dawson <marshall.dawson at se-eng.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd at gmail.com>
Gerrit-Reviewer: Richard Spiegel <richard.spiegel at silverbackltd.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-CC: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Comment-Date: Fri, 21 Sep 2018 17:42:46 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180921/a30fc03f/attachment.html>
More information about the coreboot-gerrit
mailing list