[coreboot-gerrit] Change in coreboot[master]: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"

Martin Roth (Code Review) gerrit at coreboot.org
Fri Sep 21 16:26:10 CEST 2018


Martin Roth has posted comments on this change. ( https://review.coreboot.org/28690 )

Change subject: Revert "mb/google/poppy/variants/nautilus: Set grip sensor threshold"
......................................................................


Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/28690/2//COMMIT_MSG
Commit Message:

https://review.coreboot.org/#/c/28690/2//COMMIT_MSG@11
PS2, Line 11: Reason for revert: b:113303916
Please remember that this is an open source project and most people can't see this bug.  A comment like this would be more appropriate:

 Use values from driver instead of hardcoding in firmware ( b:113303916)



-- 
To view, visit https://review.coreboot.org/28690
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02d21803f38da227f1d85b00cb6b5274d81dbbb4
Gerrit-Change-Number: 28690
Gerrit-PatchSet: 2
Gerrit-Owner: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: Enrico Granata <egranata at chromium.org>
Gerrit-Reviewer: Enrico Granata <egranata at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Seunghwan Kim <sh_.kim at samsung.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Fri, 21 Sep 2018 14:26:10 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180921/ebd1a0c1/attachment.html>


More information about the coreboot-gerrit mailing list