[coreboot-gerrit] Change in coreboot[master]: include/device/pnp.h: Don't use device_t

Martin Roth (Code Review) gerrit at coreboot.org
Fri Sep 21 16:11:57 CEST 2018


Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/28676 )

Change subject: include/device/pnp.h: Don't use device_t
......................................................................

include/device/pnp.h: Don't use device_t

Use of device_t is deprecated.

Change-Id: I9364c9681dd89f09480368a997f6d1f04cde1488
Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
Reviewed-on: https://review.coreboot.org/28676
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
M src/include/device/pnp.h
1 file changed, 18 insertions(+), 18 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Jonathan Neuschäfer: Looks good to me, approved



diff --git a/src/include/device/pnp.h b/src/include/device/pnp.h
index d753013..69e0f8f 100644
--- a/src/include/device/pnp.h
+++ b/src/include/device/pnp.h
@@ -10,21 +10,21 @@
 #ifndef __SIMPLE_DEVICE__
 
 /* Primitive PNP resource manipulation */
-void pnp_write_config(device_t dev, u8 reg, u8 value);
-u8 pnp_read_config(device_t dev, u8 reg);
-void pnp_set_logical_device(device_t dev);
-void pnp_set_enable(device_t dev, int enable);
-int pnp_read_enable(device_t dev);
-void pnp_set_iobase(device_t dev, u8 index, u16 iobase);
-void pnp_set_irq(device_t dev, u8 index, u8 irq);
-void pnp_set_drq(device_t dev, u8 index, u8 drq);
+void pnp_write_config(struct device *dev, u8 reg, u8 value);
+u8 pnp_read_config(struct device *dev, u8 reg);
+void pnp_set_logical_device(struct device *dev);
+void pnp_set_enable(struct device *dev, int enable);
+int pnp_read_enable(struct device *dev);
+void pnp_set_iobase(struct device *dev, u8 index, u16 iobase);
+void pnp_set_irq(struct device *dev, u8 index, u8 irq);
+void pnp_set_drq(struct device *dev, u8 index, u8 drq);
 
 /* PNP device operations */
-void pnp_read_resources(device_t dev);
-void pnp_set_resources(device_t dev);
-void pnp_enable_resources(device_t dev);
-void pnp_enable(device_t dev);
-void pnp_alt_enable(device_t dev);
+void pnp_read_resources(struct device *dev);
+void pnp_set_resources(struct device *dev);
+void pnp_enable_resources(struct device *dev);
+void pnp_enable(struct device *dev);
+void pnp_alt_enable(struct device *dev);
 
 extern struct device_operations pnp_ops;
 
@@ -60,16 +60,16 @@
 #define PNP_MSCE 0x800000
 	u16 io0, io1, io2, io3;
 };
-struct resource *pnp_get_resource(device_t dev, unsigned int index);
+struct resource *pnp_get_resource(struct device *dev, unsigned int index);
 void pnp_enable_devices(struct device *dev, struct device_operations *ops,
 			unsigned int functions, struct pnp_info *info);
 
 struct pnp_mode_ops {
-	void (*enter_conf_mode)(device_t dev);
-	void (*exit_conf_mode)(device_t dev);
+	void (*enter_conf_mode)(struct device *dev);
+	void (*exit_conf_mode)(struct device *dev);
 };
-void pnp_enter_conf_mode(device_t dev);
-void pnp_exit_conf_mode(device_t dev);
+void pnp_enter_conf_mode(struct device *dev);
+void pnp_exit_conf_mode(struct device *dev);
 
 /* PNP indexed I/O operations */
 

-- 
To view, visit https://review.coreboot.org/28676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9364c9681dd89f09480368a997f6d1f04cde1488
Gerrit-Change-Number: 28676
Gerrit-PatchSet: 4
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180921/e374be17/attachment.html>


More information about the coreboot-gerrit mailing list