[coreboot-gerrit] Change in coreboot[master]: mb/google/octopus: Create ampton variant

Thu Sep 20 19:26:05 CEST 2018

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28663 )

Change subject: mb/google/octopus: Create ampton variant
......................................................................

Patch Set 7:

(117 comments)

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c
File src/mainboard/google/octopus/variants/ampton/gpio.c:

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@35
PS7, Line 35: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_8, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_CLK_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@36
PS7, Line 36: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_9, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA0_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@37
PS7, Line 37: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_10, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA1_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@38
PS7, Line 38: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_11, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA2_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@39
PS7, Line 39: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_12, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA3_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@40
PS7, Line 40: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_13, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA4_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@41
PS7, Line 41: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_14, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA5_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@42
PS7, Line 42: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_15, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA6_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@43
PS7, Line 43: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_16, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_0_DATA7_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@44
PS7, Line 44: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_17, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_CLK_1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@45
PS7, Line 45: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_18, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_8 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@46
PS7, Line 46: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_19, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_9 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@47
PS7, Line 47: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_20, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* DBG_PTI_DATA_10 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@49
PS7, Line 49: 	PAD_CFG_NF_IOSSTATE(GPIO_22, UP_20K, DEEP, NF2, TxDRxE), /* CNV_MFUART2_TXD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@51
PS7, Line 51: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_24, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_1_DATA6_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@52
PS7, Line 52: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_25, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_1_DATA7_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@53
PS7, Line 53: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_26, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_CLK_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@54
PS7, Line 54: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_27, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA0_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@55
PS7, Line 55: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_28, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA1_VNN 0*/
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@56
PS7, Line 56: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_29, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA2_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@57
PS7, Line 57: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_30, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA3_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@58
PS7, Line 58: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_31, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA4_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@59
PS7, Line 59: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_32, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA5_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@60
PS7, Line 60: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_33, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA6_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@61
PS7, Line 61: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_34, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_2_DATA7_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@62
PS7, Line 62: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_35, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_CLK_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@63
PS7, Line 63: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_36, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA0_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@64
PS7, Line 64: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_37, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA1_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@65
PS7, Line 65: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_38, DN_20K, DEEP, NF5, HIZCRx0, DISPUPD), /* TRACE_3_DATA2_VNN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@70
PS7, Line 70: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_43, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* GP_INTD_DSI_TE2 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@71
PS7, Line 71: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_44, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_OC0_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@72
PS7, Line 72: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_45, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* USB_OC1_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@79
PS7, Line 79: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_50, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@80
PS7, Line 80: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_51, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C0_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@81
PS7, Line 81: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_52, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C1_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@82
PS7, Line 82: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_53, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C1_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@85
PS7, Line 85: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_56, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C3_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@86
PS7, Line 86: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_57, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_I2C2_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@89
PS7, Line 89: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_60, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_RXD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@90
PS7, Line 90: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_61, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART0_TXD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@92
PS7, Line 92: 	PAD_CFG_GPI_APIC_IOS(GPIO_63, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD), /* H1_PCH_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@93
PS7, Line 93: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_64, UP_20K, DEEP, NF1, HIZCRx1, DISPUPD), /* LPSS_UART2_RXD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@94
PS7, Line 94: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_65, UP_20K, DEEP, NF1, TxLASTRxE, DISPUPD), /* LPSS_UART2_TXD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@103
PS7, Line 103: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_74, UP_20K, DEEP, NF1, TxDRxE, ENPU), /* THERMTRIP_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@104
PS7, Line 104: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_75, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PROCHOT_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@106
PS7, Line 106: 	PAD_CFG_GPI_APIC_IOS(GPIO_212, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD), /* Touch Panel Int */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@118
PS7, Line 118: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_79, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* H1_SLAVE_SPI_CLK_R */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@119
PS7, Line 119: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_80, NONE, DEEP, NF1, HIZCRx1, DISPUPD), /* H1_SLAVE_SPI_CS_L_R */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@120
PS7, Line 120: 	PAD_CFG_GPIO_HI_Z(GPIO_81, UP_20K, DEEP, HIZCRx0, DISPUPD), /* GPIO_81_DEBUG (Boot halt) -- MIPI60 DEBUG */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@131
PS7, Line 131: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_90, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_CS0_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@132
PS7, Line 132: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_91, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD),/* FST_SPI_CS1_B -- SPK_PA_EN_R */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@133
PS7, Line 133: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_92, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MOSI_IO0 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@134
PS7, Line 134: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_93, NATIVE, DEEP, NF1, HIZCRx1, SAME),/* FST_SPI_MISO_IO1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@137
PS7, Line 137: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_96, NATIVE, DEEP, NF1, HIZCRx0, SAME),/* FST_SPI_CLK */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@140
PS7, Line 140: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_98, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_PLTRST_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@141
PS7, Line 141: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_99, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_PWRBTN_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@142
PS7, Line 142: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_100, NONE, DEEP, NF1),/* PMU_SLP_S0_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@143
PS7, Line 143: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_101, NONE, DEEP, NF1),/* PMU_SLP_S3_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@144
PS7, Line 144: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_102, NONE, DEEP, NF1),/* PMU_SLP_S4_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@147
PS7, Line 147: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_105, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_105 -- TOUCHSCREEN_RST */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@148
PS7, Line 148: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_106, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* PMU_BATLOW_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@149
PS7, Line 149: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_107, NONE, DEEP, NF1, TxDRxE, DISPUPD),/* PMU_RESETBUTTON_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@151
PS7, Line 151: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_109, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD),/* SUS_STAT_B -- BT_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@154
PS7, Line 154: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_110, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C5_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@155
PS7, Line 155: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_111, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C5_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@158
PS7, Line 158: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_112, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C6_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@159
PS7, Line 159: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_113, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C6_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@162
PS7, Line 162: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_114, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C7_SDA */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@163
PS7, Line 163: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_115, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* LPSS_I2C7_SCL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@166
PS7, Line 166: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_116, 1, DEEP, NONE, Tx1RxDCRx1, DISPUPD), /* PCIE_WAKE0_B -- WIFI_DISABLE_L */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@167
PS7, Line 167: 	PAD_CFG_GPI_SCI_LOW(GPIO_117, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE1_B -- LTE_WAKE_L */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@169
PS7, Line 169: 	PAD_CFG_GPI_SCI_LOW(GPIO_119, NONE, DEEP, EDGE_SINGLE),/* PCIE_WAKE3_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@176
PS7, Line 176: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_120, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ0_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@177
PS7, Line 177: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_121, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ1_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@178
PS7, Line 178: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_122, UP_20K, DEEP, NF1, HIZCRx1, ENPU),/* PCIE_CLKREQ2_B -- unused */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@179
PS7, Line 179: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_123, NONE, DEEP, NF1, TxDRxE, DISPUPD), /* PCIE_CLKREQ3_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@188
PS7, Line 188: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_128, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_VDDEN*/
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@189
PS7, Line 189: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_129, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_BKLTEN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@190
PS7, Line 190: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_130, NONE, DEEP, NF1, Tx0RxDCRx0, DISPUPD),/* PANEL0_BKLTCTL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@193
PS7, Line 193: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_131, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_DDI0_HPD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@194
PS7, Line 194: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_132, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_DDI1_HPD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@195
PS7, Line 195: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_133, NONE, DEEP, NF1, HIZCRx1, DISPUPD),/* HV_EDP_HPD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@198
PS7, Line 198: 	PAD_CFG_GPI_APIC_IOS(GPIO_135, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_135 -- TRACKPAD_INT1_1V8_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@199
PS7, Line 199: 	PAD_CFG_GPI_APIC_IOS(GPIO_136, NONE, DEEP, LEVEL, INVERT, TxDRxE, DISPUPD),/* GPIO_136 -- PMIC_PCH_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@202
PS7, Line 202: 	PAD_CFG_GPI_APIC_IOS(GPIO_138, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_138 -- PEN_PDCT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@203
PS7, Line 203: 	PAD_CFG_GPI_APIC_IOS(GPIO_139, NONE, DEEP, LEVEL, INVERT, HIZCRx1, DISPUPD),/* GPIO_139 -- PEN_INT_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@204
PS7, Line 204: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_140, 0, DEEP, NONE, Tx1RXDCRx0, DISPUPD),/* GPIO_140 -- PEN_RESET */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@206
PS7, Line 206: 	PAD_CFG_GPI_SCI_IOS(GPIO_141, NONE, DEEP, EDGE_SINGLE, INVERT, IGNORE, DISPUPD),/* GPIO_141 -- EC_PCH_WAKE_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@207
PS7, Line 207: 	PAD_CFG_GPI_SCI_LOW(GPIO_142, NONE, DEEP, LEVEL),/* GPIO_142 -- TRACKPAD_INT2_1V8_ODL */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@211
PS7, Line 211: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_146, 0, DEEP, NONE, Tx0RxDCRx0, DISPUPD), /* EN_PP3300_TOUCHSCREEN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@226
PS7, Line 226: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_162, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@227
PS7, Line 227: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_163, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_WS_SYNC */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@229
PS7, Line 229: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_165, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_I2S1_SDO */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@230
PS7, Line 230: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_166, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_BCLK */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@231
PS7, Line 231: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_167, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_WS_SYNC */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@232
PS7, Line 232: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_168, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_SDI */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@233
PS7, Line 233: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_169, NONE, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S2_SD0 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@234
PS7, Line 234: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_170, DN_20K, DEEP, NF2, HIZCRx0, DISPUPD), /* AVS_I2S1_MCLK */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@237
PS7, Line 237: 	PAD_CFG_NF_IOSSTATE(GPIO_171, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_CLK_A1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@238
PS7, Line 238: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_172, DN_20K, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_CLK_B1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@239
PS7, Line 239: 	PAD_CFG_NF_IOSSTATE(GPIO_173, DN_20K, DEEP, NF1, HIZCRx0), /* AVS_M_DATA_1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@241
PS7, Line 241: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_175, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* AVS_M_DATA_2 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@246
PS7, Line 246: 	PAD_CFG_GPO_IOSSTATE_IOSTERM(GPIO_178, 1, DEEP, NONE, Tx1RXDCRx0, DISPUPD), /* EN_PP3300_WLAN */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@265
PS7, Line 265: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_192, UP_20K, DEEP, NF1), /* CNV_BRI_RSP */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@267
PS7, Line 267: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_194, UP_20K, DEEP, NF1), /* CNV_RGI_RSP */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@268
PS7, Line 268: 	PAD_CFG_NF_IOSTANDBY_IGNORE(GPIO_195, NONE, DEEP, NF1), /* CNV_RF_RESET_B */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@269
PS7, Line 269: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_198, DN_20K, DEEP, NF1, HIZCRx0, ENPD), /* EMMC0_CLK */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@270
PS7, Line 270: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_200, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D0 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@271
PS7, Line 271: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_201, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D1 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@272
PS7, Line 272: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_202, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D2 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@273
PS7, Line 273: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_203, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D3 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@274
PS7, Line 274: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_204, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D4 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@275
PS7, Line 275: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_205, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D5 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@276
PS7, Line 276: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_206, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D6 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@277
PS7, Line 277: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_207, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_D7 */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@278
PS7, Line 278: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_208, UP_20K, DEEP, NF1, HIZCRx1, ENPU), /* EMMC0_CMD */
line over 80 characters

https://review.coreboot.org/#/c/28663/7/src/mainboard/google/octopus/variants/ampton/gpio.c@279
PS7, Line 279: 	PAD_CFG_NF_IOSSTATE_IOSTERM(GPIO_209, NONE, DEEP, NF1, HIZCRx0, DISPUPD), /* EMMC0_STROBE */
line over 80 characters

-- 
To view, visit https://review.coreboot.org/28663
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d6cf19c906df19115b1101e3d91c62f5f3f61e3
Gerrit-Change-Number: 28663
Gerrit-PatchSet: 7
Gerrit-Owner: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin at chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Jett Rink <jettrink at google.com>
Gerrit-Reviewer: Justin TerAvest <teravest at chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 17:26:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/759b6077/attachment.html>