[coreboot-gerrit] Change in coreboot[master]: drivers/spi/winbond: Add function to lock flash's status register
build bot (Jenkins) (Code Review)
gerrit at coreboot.org
Thu Sep 20 13:13:59 CEST 2018
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28697 )
Change subject: drivers/spi/winbond: Add function to lock flash's status register
......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c
File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@552
PS1, Line 552: val = (union status_reg1_bp3){ .srp0 = !!(mode & 1) }.u;
space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@553
PS1, Line 553: mask = (union status_reg1_bp3){ .srp0 = 1 }.u;
space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@555
PS1, Line 555: val = (union status_reg1_bp4){ .srp0 = !!(mode & 1) }.u;
space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@556
PS1, Line 556: mask = (union status_reg1_bp4){ .srp0 = 1 }.u;
space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@563
PS1, Line 563: val = (union status_reg2){ .srp1 = !!(mode & 2) }.u;
space required after that close brace '}'
https://review.coreboot.org/#/c/28697/1/src/drivers/spi/winbond.c@564
PS1, Line 564: mask = (union status_reg2){ .srp1 = 1 }.u;
space required after that close brace '}'
--
To view, visit https://review.coreboot.org/28697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I90e0fcdcf531b53c0fc1ffcfdb3b5ab522f088f5
Gerrit-Change-Number: 28697
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph <patrick.rudolph at 9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Sep 2018 11:13:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/0f251a31/attachment.html>
More information about the coreboot-gerrit
mailing list