[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Make usage of SMI optional where possible

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28696 )

Change subject: soc/intel/skylake: Make usage of SMI optional where possible
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28696/1/src/ec/google/chromeec/ec.c
File src/ec/google/chromeec/ec.c:

https://review.coreboot.org/#/c/28696/1/src/ec/google/chromeec/ec.c@491
PS1, Line 491: 	 * stage and ACPI_DISABLE calls can explicitely disable it
'explicitely' may be misspelled - perhaps 'explicitly'?


https://review.coreboot.org/#/c/28696/1/src/soc/intel/skylake/finalize.c
File src/soc/intel/skylake/finalize.c:

https://review.coreboot.org/#/c/28696/1/src/soc/intel/skylake/finalize.c@147
PS1, Line 147: 	if (!IS_ENABLED(CONFIG_REDUCED_SMI)){
space required before the open brace '{'



-- 
To view, visit https://review.coreboot.org/28696
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f0c64b15ed6d0854ff350fcd75d299e45c23f18
Gerrit-Change-Number: 28696
Gerrit-PatchSet: 1
Gerrit-Owner: dhaval v sharma <dhaval.v.sharma at intel.com>
Gerrit-CC: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Thu, 20 Sep 2018 09:49:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/ea3d95f2/attachment.html>