[coreboot-gerrit] Change in coreboot[master]: mb/solidrun/solidpc: Do initial commit

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Thu Sep 20 11:38:23 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/23027 )

Change subject: mb/solidrun/solidpc: Do initial commit
......................................................................


Patch Set 7:

(262 comments)

https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c
File src/mainboard/solidrun/solidpc/gpio.c:

https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@67
PS7, Line 67: 	/*SE00 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@69
PS7, Line 69: 	/*SE02 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@70
PS7, Line 70: 	/*SE03 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@71
PS7, Line 71: 	/*SE04 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@73
PS7, Line 73: 	/*SE06 */ { .pad_conf0 = 0x00130300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@74
PS7, Line 74: 	/*SE07 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@99
PS7, Line 99: 	/*SE16 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@100
PS7, Line 100: 	/*SE17 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@103
PS7, Line 103: 	/*SE20 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@106
PS7, Line 106: 	/*SE23 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@107
PS7, Line 107: 	/*SE24 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@109
PS7, Line 109: 	/*SE26 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@124
PS7, Line 124: 	/*SE30 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@125
PS7, Line 125: 	/*SE31 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@126
PS7, Line 126: 	/*SE32 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@127
PS7, Line 127: 	/*SE33 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@128
PS7, Line 128: 	/*SE34 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@129
PS7, Line 129: 	/*SE35 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@148
PS7, Line 148: 	/*SE45 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@149
PS7, Line 149: 	/*SE46 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@150
PS7, Line 150: 	/*SE47 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@151
PS7, Line 151: 	/*SE48 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@153
PS7, Line 153: 	/*SE50 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@154
PS7, Line 154: 	/*SE51 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@155
PS7, Line 155: 	/*SE52 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@165
PS7, Line 165: 	// GPI(trig_edge_low, L5, P_20K_H, non_maskable, en_rx_data, UNMASK_WAKE , NA),	/* 60 SPI1_MISO */	/* PMIC_IRQ_1P8 */	/* Open drain? */	/* FIXME: InvRX_Enable - is this connected to the PMIC? */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@171
PS7, Line 171: 	// GPIO_OUT_HIGH,	/* 66 SPI1_CS1_B */	/* LAN P0 ISOLATE */	/* FIXME: check if this pin is actually used as P0 Isolate */	//FIXME: Find P1 isolate
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@176
PS7, Line 176: 	/*SE60 */ { .pad_conf0 = 0x58918200, .pad_conf1 = 0x05C00019, .wake_mask = 1, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@177
PS7, Line 177: 	/*SE61 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@178
PS7, Line 178: 	/*SE62 */ { .pad_conf0 = 0x4C918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@179
PS7, Line 179: 	/*SE63 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@180
PS7, Line 180: 	/*SE64 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@181
PS7, Line 181: 	/*SE65 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@182
PS7, Line 182: 	/*SE66 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@183
PS7, Line 183: 	/*SE67 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@184
PS7, Line 184: 	/*SE68 */ { .pad_conf0 = 0x00910381, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@196
PS7, Line 196: 	// Native_M1,		/* 75 USB_OC1_B */		/* USB_OC1_B */			/* FIXME: pulls? */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@197
PS7, Line 197: 	// Native_M1,		/* 76 PMU_RESETBUTTON_B */	/* PMU_RESETBUTTON_B */		/* FIXME: pulls? */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@199
PS7, Line 199: 	// Native_M1,		/* 78 SDMMC3_PWR_EN_B */	/* SD_CARD_PWRDN_N */		/* FIXME: pulls? */	//FIXME: Connected?
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@201
PS7, Line 201: 	// Native_M1,		/* 80 USB_OC0_B */		/* USB_OC0_B */			/* FIXME: pulls? */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@202
PS7, Line 202: 	// NATIVE_INT_PU20K(1, L1),	/* 81 SDMMC3_CD_B */	/* SD_CARD_DET_N */		/* FIXME: Native M1, no pull, trig_level, invert */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@205
PS7, Line 205: 	// Native_M1,		/* 84 SDMMC1_RCLK */		/* SDMMC1_RCLK */		/* FIXME: no SPARE_PIN!? check if NC */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@206
PS7, Line 206: 	// Native_M1,		/* 85 SDMMC3_1P8_EN */		/* SD_CARD_PWR_EN */		/* FIXME: check if NC */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@208
PS7, Line 208: 	/*SE75 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@209
PS7, Line 209: 	/*SE76 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@210
PS7, Line 210: 	/*SE77 */ { .pad_conf0 = 0x14918201, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@211
PS7, Line 211: 	/*SE78 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@212
PS7, Line 212: 	/*SE79 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@213
PS7, Line 213: 	/*SE80 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@214
PS7, Line 214: 	/*SE81 */ { .pad_conf0 = 0x10910300, .pad_conf1 = 0x05C00004, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@216
PS7, Line 216: 	/*SE83 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@217
PS7, Line 217: 	/*SE84 */ { .pad_conf0 = 0x00110380, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@218
PS7, Line 218: 	/*SE85 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@238
PS7, Line 238: 	// Native_M1,	/* 06 FST_SPI_CS0_B */		/* SPI_CS (SPI NOR on SOM) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@241
PS7, Line 241: 	/*SW00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@242
PS7, Line 242: 	/*SW01 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@243
PS7, Line 243: 	/*SW02 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@244
PS7, Line 244: 	/*SW03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@245
PS7, Line 245: 	/*SW04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@246
PS7, Line 246: 	/*SW05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@247
PS7, Line 247: 	/*SW06 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@248
PS7, Line 248: 	/*SW07 */ { .pad_conf0 = 0x00218100, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@258
PS7, Line 258: 	// Native_M2,	/* 16 UART1_RXD */		/* UART1_RXD */		//NOTE: set to UART0 for debugging
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@262
PS7, Line 262: 	// Native_M2,	/* 20 UART1_TXD */		/* UART1_TXD */		//NOTE: set to UART0 for debugging
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@266
PS7, Line 266: 	/*SW15 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@267
PS7, Line 267: 	/*SW16 */ GPIO_SKIP, //{ .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@268
PS7, Line 268: 	/*SW17 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@270
PS7, Line 270: 	/*SW19 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@272
PS7, Line 272: 	/*SW21 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@273
PS7, Line 273: 	/*SW22 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@282
PS7, Line 282: 	// Native_M2,	/* 30 MF_HDA_CLK */			/* MF_HDA_CLK II GP_SSP_0_I2S_TXD */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@283
PS7, Line 283: 	// Native_M2,	/* 31 GPIO_SW31/MF_HDA_RSTB */		/* AUD_LINK_RST_N || I2S_0_CLK_R_AICO (AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@284
PS7, Line 284: 	// Native_M2,	/* 32 GPIO_SW32 /MF_HDA_SDI0 */		/* AUD_LINK_SDI0 (ALC282) || I2S_2_CLK_R_AICO (AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@285
PS7, Line 285: 	// Native_M2,	/* 33 MF_HDA_SDO */			/* AUD_LINK_SDO_R||I2S_0_RXD_R_AICO (AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@286
PS7, Line 286: 	// GPIO_NC,	/* 34 MF_HDA_DOCKRSTB */		/* I2S_2_TXD_R_AICO (AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@287
PS7, Line 287: 	// Native_M2,	/* 35 MF_HDA_SYNC */			/* AUD_LINKSYNC_R|| I2S_0_FS_R_AICO (AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@288
PS7, Line 288: 	// GPIO_NC,	/* 36 GPIO_SW36 MF_HDA_SDI1 */		/* I2S_2_FS_R_AICO */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@289
PS7, Line 289: 	// GPIO_NC,	/* 37 MF_HDA_DOCKENB */			/* I2S_2_RXD_R_AICO(AIC) */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@291
PS7, Line 291: 	/*SW30 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@292
PS7, Line 292: 	/*SW31 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@293
PS7, Line 293: 	/*SW32 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@294
PS7, Line 294: 	/*SW33 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@295
PS7, Line 295: 	/*SW34 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@296
PS7, Line 296: 	/*SW35 */ { .pad_conf0 = 0x00120300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@297
PS7, Line 297: 	/*SW36 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@298
PS7, Line 298: 	/*SW37 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@306
PS7, Line 306: 	// GPIO_NC,			/* 45 I2C5_SDA */	/* Touch Panel */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@307
PS7, Line 307: 	// NATIVE_PU1K_CSEN_INVTX(1),	/* 46 I2C4_SDA */	/* I2C Audio | Touch PAD */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@309
PS7, Line 309: 	// GPIO_NC,			/* 48 I2C5_SCL */	/* Touch Panel */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@311
PS7, Line 311: 	// NATIVE_PU1K_CSEN_INVTX(1),	/* 50 I2C4_SCL */	/* I2C Audio | Touch PAD */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@315
PS7, Line 315: 	/*SW45 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@316
PS7, Line 316: 	/*SW46 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@317
PS7, Line 317: 	/*SW47 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@318
PS7, Line 318: 	/*SW48 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@320
PS7, Line 320: 	/*SW50 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@321
PS7, Line 321: 	/*SW51 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@331
PS7, Line 331: 	// GPIO_NC,			/* 61 I2C0_SDA */	/* 3rd party Sensor Card */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@332
PS7, Line 332: 	// GPIO_NC,			/* 62 I2C2_SDA */	/* MIPI_CSI CAMERAS, FLASH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@334
PS7, Line 334: 	// GPIO_NC,			/* 64 I2C3_SDA */	/* MIPI_CSI CAMERAS, FLASH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@335
PS7, Line 335: 	// GPIO_NC,			/* 65 I2C0_SCL */	/* 3rd party Sensor Card */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@336
PS7, Line 336: 	// GPIO_NC,			/* 66 I2C2_SCL */	/* MIPI_CSI CAMERAS, FLASH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@337
PS7, Line 337: 	// GPIO_NC,			/* 67 I2C3_SCL */	/* MIPI_CSI CAMERAS, FLASH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@339
PS7, Line 339: 	/*SW60 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@340
PS7, Line 340: 	/*SW61 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@341
PS7, Line 341: 	/*SW62 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@342
PS7, Line 342: 	/*SW63 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@343
PS7, Line 343: 	/*SW64 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@344
PS7, Line 344: 	/*SW65 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@345
PS7, Line 345: 	/*SW66 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@346
PS7, Line 346: 	/*SW67 */ { .pad_conf0 = 0x00C10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@355
PS7, Line 355: 	// GPIO_NC,		/* 75 SATA_GP0 */			/* TOUCH_PNL_RST_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@356
PS7, Line 356: 	// GPIO_NC,		/* 76 SATA_GP1 */			/* TOUCH_INT_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@357
PS7, Line 357: 	// Native_M1,		/* 77 SATA_LEDN */			/* SATA_LED_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@358
PS7, Line 358: 	// Native_M1,		/* 78 SATA_GP2 */			/* SATA_DEVSLP_R */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@359
PS7, Line 359: 	// GPIO_NC,		/* 79 MF_SMB_ALERTB */			/* MF_SMB_ALERTB */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@360
PS7, Line 360: 	// Native_M1,		/* 80 SATA_GP3 */			/* eMMC_RST_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@361
PS7, Line 361: 	// GPIO_NC,		/* 81 NFC_DEV_WAKE , MF_SMB_CLK */	/* MF_SMB_CLK */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@362
PS7, Line 362: 	// GPIO_NC,		/* 82 NFC_FW_DOWNLOAD, MF_SMB_DATA */	/* MF_SMB_DATA */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@364
PS7, Line 364: 	/*SW75 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@365
PS7, Line 365: 	/*SW76 */ { .pad_conf0 = 0x0CC18200, .pad_conf1 = 0x05C00011, .wake_mask = 0, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@366
PS7, Line 366: 	/*SW77 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@367
PS7, Line 367: 	/*SW78 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@369
PS7, Line 369: 	/*SW80 */ { .pad_conf0 = 0x00110002, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@385
PS7, Line 385: 	// Native_M1,	/* 95 PCIE_CLKREQ3B */	/* Tied to Micro SD */		//FIXME: What does this pin do? Is it even a CLKREQ?
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@389
PS7, Line 389: 	/*SW90 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@390
PS7, Line 390: 	/*SW91 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@392
PS7, Line 392: 	/*SW93 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@394
PS7, Line 394: 	/*SW95 */ { .pad_conf0 = 0x00910300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@412
PS7, Line 412: //	GPIO_OUT_HIGH,		/* 00 GPIO_DFX0 */	/* LAN P0 RESET */	//FIXME: Is this a reset?
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@422
PS7, Line 422: 	/*N00 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@423
PS7, Line 423: 	/*N01 */ { .pad_conf0 = 0x2C018200, .pad_conf1 = 0x05C00021, .wake_mask = 0, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@425
PS7, Line 425: 	/*N03 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@426
PS7, Line 426: 	/*N04 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@427
PS7, Line 427: 	/*N05 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@428
PS7, Line 428: 	/*N06 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@429
PS7, Line 429: 	/*N07 */ { .pad_conf0 = 0x00918202, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@430
PS7, Line 430: 	/*N08 */ { .pad_conf0 = 0x00918203, .pad_conf1 = 0x00918001, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@444
PS7, Line 444: //	GPI(trig_edge_low, L1, P_1K_H, non_maskable, NA, UNMASK_WAKE, NA),	/* 18 GPIO_SUS7 */	/* GPIO_SUS7 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@445
PS7, Line 445: //	Native_M6,		/* 19 GPIO_SUS1 */		/* GPIO_SUS1 */		//NOTE: configured as PCI_WAKE1_N, but is just a pin on the headers
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@446
PS7, Line 446: //	Native_M1,		/* 20 GPIO_SUS5 */		/* GPIO_SUS5 */		//FIXME: What's the native mode of this pin? docs only say strapping pin for Flash Descriptor Security Override
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@448
PS7, Line 448: //	Native_M6,		/* 22 GPIO_SUS4 */		/*  */			//NOTE: configured as PCI_WAKE4_N //FIXME: What's on this pin?
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@450
PS7, Line 450: //	Native_M6,		/* 24 GPIO_SUS2 */		/* GPIO_SUS2 */		//NOTE: configured as PCI_WAKE2_N, but is just a pin on the headers
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@456
PS7, Line 456: 	/*N15 */ { .pad_conf0 = 0x3C018200, .pad_conf1 = 0x05C00001, .wake_mask = 1, .int_mask = 1, .gpe = SCI },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@458
PS7, Line 458: 	/*N17 */ { .pad_conf0 = 0x4C118200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@459
PS7, Line 459: 	/*N18 */ { .pad_conf0 = 0xFC918200, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SMI },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@460
PS7, Line 460: 	/*N19 */ { .pad_conf0 = 0x00160301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@461
PS7, Line 461: 	/*N20 */ { .pad_conf0 = 0x00910201, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@463
PS7, Line 463: 	/*N22 */ { .pad_conf0 = 0x00960301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@465
PS7, Line 465: 	/*N24 */ { .pad_conf0 = 0x00918102, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@466
PS7, Line 466: 	/*N25 */ { .pad_conf0 = 0xEC918201, .pad_conf1 = 0x05C00001, .wake_mask = 0, .int_mask = 1, .gpe = SCI },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@493
PS7, Line 493: 	/*N30 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@494
PS7, Line 494: 	/*N31 */ { .pad_conf0 = 0x00210300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@495
PS7, Line 495: 	/*N32 */ { .pad_conf0 = 0x00010301, .pad_conf1 = 0x05C00060, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@497
PS7, Line 497: 	/*N34 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@498
PS7, Line 498: 	/*N35 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@499
PS7, Line 499: 	/*N36 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@500
PS7, Line 500: 	/*N37 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@502
PS7, Line 502: 	/*N39 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@504
PS7, Line 504: 	/*N41 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@529
PS7, Line 529: 	/*N45 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@530
PS7, Line 530: 	/*N46 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@531
PS7, Line 531: 	/*N47 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@532
PS7, Line 532: 	/*N48 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@533
PS7, Line 533: 	/*N49 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@534
PS7, Line 534: 	/*N50 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@535
PS7, Line 535: 	/*N51 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@536
PS7, Line 536: 	/*N52 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@537
PS7, Line 537: 	/*N53 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@538
PS7, Line 538: 	/*N54 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@539
PS7, Line 539: 	/*N55 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@540
PS7, Line 540: 	/*N56 */ { .pad_conf0 = 0x00118000, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@555
PS7, Line 555: //	Native_M1,		/* 62 HV_DDI2_DDC_SDA */	/* DDI2_SDA_1P8 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@556
PS7, Line 556: //	Native_M1,		/* 63 PANEL1_BKLTCTL */		/* PANEL1_BKLTCTL */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@559
PS7, Line 559: //	Native_M1,		/* 66 HV_DDI0_DDC_SDA */	/* DDI0_1_SDA_1P8 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@560
PS7, Line 560: //	Native_M1,		/* 67 HV_DDI2_DDC_SCL */	/* DDI2_SCL_1P8 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@562
PS7, Line 562: //	Native_M1,		/* 69 PANEL1_VDDEN */		/* PANEL1_VDDEN */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@563
PS7, Line 563: //	Native_M1,		/* 70 PANEL1_BKLTEN */		/* PANEL1_BKLTEN */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@564
PS7, Line 564: //	GPIO_NC,		/* 71 HV_DDI0_DDC_SCL */	/* DDI0_1_SCL_1P8 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@567
PS7, Line 567: 	/*N60 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@568
PS7, Line 568: 	/*N61 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@569
PS7, Line 569: 	/*N62 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@570
PS7, Line 570: 	/*N63 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@571
PS7, Line 571: 	/*N64 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@572
PS7, Line 572: 	/*N65 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@573
PS7, Line 573: 	/*N66 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@574
PS7, Line 574: 	/*N67 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x04C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@575
PS7, Line 575: 	/*N68 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@576
PS7, Line 576: 	/*N69 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@577
PS7, Line 577: 	/*N70 */ { .pad_conf0 = 0x00010300, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@578
PS7, Line 578: 	/*N71 */ { .pad_conf0 = 0x00920301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@595
PS7, Line 595: 	// Native_M1,		/* 00 PMU_SLP_S3_B */		/* PMU_SLP_S3_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@596
PS7, Line 596: 	// Native_M1,		/* 01 PMU_BATLOW_B */		/* PMU_BATLOW_B */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@599
PS7, Line 599: 	// Native_M1,		/* 04 PMU_AC_PRESENT */		/* PMU_AC_PRESENT */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@600
PS7, Line 600: 	// Native_M1,		/* 05 PMU_PLTRST_B */		/* PMU_PLTRST_B */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@601
PS7, Line 601: 	// Native_M1,		/* 06 PMU_SUSCLK */		/* PMU_SUSCLK_1P8 */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@603
PS7, Line 603: 	// Native_M1,		/* 08 PMU_PWRBTN_B */		/* PMU_PWRBTN_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@604
PS7, Line 604: 	// Native_M1,		/* 09 PMU_SLP_S4_B */		/* PMU_SLP_S4_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@605
PS7, Line 605: 	// NATIVE_FUNC(M1, P_1K_H, NA),				/* 10 PMU_WAKE_B */		/* PMU_WAKE_N */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@606
PS7, Line 606: 	// GPIO_NC,		/* 11 PMU_WAKE_LAN_B */		/* PMU_WAKE_LAN_N */		/* FIXME: Does this connect to onboard RTL8111? */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@608
PS7, Line 608: 	/*E00 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@609
PS7, Line 609: 	/*E01 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@610
PS7, Line 610: 	/*E02 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@611
PS7, Line 611: 	/*E03 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@612
PS7, Line 612: 	/*E04 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@613
PS7, Line 613: 	/*E05 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@614
PS7, Line 614: 	/*E06 */ { .pad_conf0 = 0x00110301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@616
PS7, Line 616: 	/*E08 */ { .pad_conf0 = 0X00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@617
PS7, Line 617: 	/*E09 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@618
PS7, Line 618: 	/*E10 */ { .pad_conf0 = 0X00C10301, .pad_conf1 = 0x05C00000, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@619
PS7, Line 619: 	/*E11 */ { .pad_conf0 = 0X2C918201, .pad_conf1 = 0X05C00041, .wake_mask = 1, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@630
PS7, Line 630: 	// GPIO_NC,		/* 15 MF_GPIO_3 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@631
PS7, Line 631: 	// GPIO_NC,		/* 16 MF_GPIO_7 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@632
PS7, Line 632: 	// GPIO_NC,		/* 17 MF_I2C1_SCL */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@633
PS7, Line 633: 	// GPIO_NC,		/* 18 MF_GPIO_1 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@634
PS7, Line 634: 	// GPIO_NC,		/* 19 MF_GPIO_5 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@635
PS7, Line 635: 	// GPIO_NC,		/* 20 MF_GPIO_9 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@636
PS7, Line 636: 	// GPIO_NC,		/* 21 MF_GPIO_0 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@637
PS7, Line 637: 	// GPIO_NC,		/* 22 MF_GPIO_4 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@638
PS7, Line 638: 	// GPIO_NC,		/* 23 MF_GPIO_8 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@639
PS7, Line 639: 	// GPIO_NC,		/* 24 MF_GPIO_2 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@640
PS7, Line 640: 	// GPIO_NC,		/* 25 MF_GPIO_6 */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@641
PS7, Line 641: 	// GPIO_NC,		/* 26 MF_I2C1_SDA */	/*  */		/* FIXME: NC? Braswell doesn't have an ISH */
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@643
PS7, Line 643: 	/*E15 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@644
PS7, Line 644: 	/*E16 */ { .pad_conf0 = 0x00118102, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@646
PS7, Line 646: 	/*E18 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@647
PS7, Line 647: 	/*E19 */ { .pad_conf0 = 0x00118100, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@648
PS7, Line 648: 	/*E20 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@649
PS7, Line 649: 	/*E21 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@650
PS7, Line 650: 	/*E22 */ { .pad_conf0 = 0x08918201, .pad_conf1 = 0x05C00044, .wake_mask = 0, .int_mask = 1, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@651
PS7, Line 651: 	/*E23 */ { .pad_conf0 = 0x00910301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@652
PS7, Line 652: 	/*E24 */ { .pad_conf0 = 0x00A10301, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/gpio.c@653
PS7, Line 653: 	/*E25 */ { .pad_conf0 = 0x00110300, .pad_conf1 = 0x05C00020, .wake_mask = 0, .int_mask = 0, .gpe = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqroute.h
File src/mainboard/solidrun/solidpc/irqroute.h:

https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqroute.h@21
PS7, Line 21: #define PCI_DEV_PIRQ_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/irqroute.h@36
PS7, Line 36: #define PIRQ_PIC_ROUTES \
Macros with complex values should be enclosed in parentheses


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c
File src/mainboard/solidrun/solidpc/ramstage.c:

https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@25
PS7, Line 25: /* N71:HV_DDI0_DDC_SCL	>>  0	2	0	 00	  0xFED8D458	0x00920301	 0xFED8D45C	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@26
PS7, Line 26:    N66:HV_DDI0_DDC_SDA	>>  0	2	0	 00	  0xFED8D430	0x00920301	 0xFED8D434	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@27
PS7, Line 27:    N61:HV_DDI0_HPD	>>  0	1	0	 00	  0xFED8D408	0x00110300	 0xFED8D40C	0x05C00020
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@28
PS7, Line 28:    N64:HV_DDI1_HPD	>>  0	1	0	 00	  0xFED8D420	0x00110301	 0xFED8D424	0x05C00020
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@29
PS7, Line 29:    N67:HV_DDI2_DDC_SCL	>>  0	1	0	 00	  0xFED8D438	0x00910301	 0xFED8D43C	0x04C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@30
PS7, Line 30:    N62:HV_DDI2_DDC_SDA	>>  0	1	0	 00	  0xFED8D410	0x00910301	 0xFED8D414	0x04C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@31
PS7, Line 31:    N68:HV_DDI2_HPD	>>  0	1	0	 00	  0xFED8D440	0x00110301	 0xFED8D444	0x05C00020
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@32
PS7, Line 32:    N65:PANEL0_BKLTCTL	>>  0	1	0	 00	  0xFED8D428	0x00010300	 0xFED8D42C	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@33
PS7, Line 33:    N60:PANEL0_BKLTEN	>>  0	1	0	 00	  0xFED8D400	0x00010300	 0xFED8D404	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@34
PS7, Line 34:    N72:PANEL0_VDDEN	>>  0	1	0	 00	  0xFED8D460	0x00010300	 0xFED8D464	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@35
PS7, Line 35:    N63:PANEL1_BKLTCTL	>>  0	1	0	 00	  0xFED8D418	0x00010300	 0xFED8D41C	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@36
PS7, Line 36:    N70:PANEL1_BKLTEN	>>  0	1	0	 00	  0xFED8D450	0x00010300	 0xFED8D454	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@37
PS7, Line 37:    N69:PANEL1_VDDEN	>>  0	1	0	 00	  0xFED8D448	0x00010300	 0xFED8D44C	0x05C00000
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@43
PS7, Line 43: 	{ .Name = NULL /*L"N71:HV_DDI0_DDC_SCL"*/,	.Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5458, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@44
PS7, Line 44: 	{ .Name = NULL /*L"N66:HV_DDI0_DDC_SDA"*/,	.Confg0 = 0x00920301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5430, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@45
PS7, Line 45: 	{ .Name = NULL /*L"N61:HV_DDI0_HPD"*/,		.Confg0 = 0x00110300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5408, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@46
PS7, Line 46: 	{ .Name = NULL /*L"N64:HV_DDI1_HPD"*/,	   	.Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@46
PS7, Line 46: 	{ .Name = NULL /*L"N64:HV_DDI1_HPD"*/,	   	.Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5420, .Misc = 0 },
please, no space before tabs


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@47
PS7, Line 47: 	{ .Name = NULL /*L"N67:HV_DDI2_DDC_SCL"*/,	.Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5438, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@48
PS7, Line 48: 	{ .Name = NULL /*L"N62:HV_DDI2_DDC_SDA"*/,	.Confg0 = 0x00910301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x04C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5410, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@49
PS7, Line 49: 	{ .Name = NULL /*L"N68:HV_DDI2_HPD"*/,		.Confg0 = 0x00110301, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00020, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5440, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@50
PS7, Line 50: 	{ .Name = NULL /*L"N65:PANEL0_BKLTCTL"*/,	.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5428, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@51
PS7, Line 51: 	{ .Name = NULL /*L"N60:PANEL0_BKLTEN"*/,	.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5400, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@52
PS7, Line 52: 	{ .Name = NULL /*L"N72:PANEL0_VDDEN"*/,		.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5460, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@53
PS7, Line 53: 	{ .Name = NULL /*L"N63:PANEL1_BKLTCTL"*/,	.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5418, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@54
PS7, Line 54: 	{ .Name = NULL /*L"N70:PANEL1_BKLTEN"*/,	.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5450, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@55
PS7, Line 55: 	{ .Name = NULL /*L"N69:PANEL1_VDDEN"*/,		.Confg0 = 0x00010300, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0x05C00000, .Confg1Changes = 0xFFFFFFFF, .Community = NORTH, .MmioAddr = 0x5448, .Misc = 0 },
line over 80 characters


https://review.coreboot.org/#/c/23027/7/src/mainboard/solidrun/solidpc/ramstage.c@56
PS7, Line 56: 	{ .Name = NULL /*L""*/,				.Confg0 = 0xFFFFFFFF, .Confg0Changes = 0xFFFFFFFF, .Confg1 = 0xFFFFFFFF, .Confg1Changes = 0xFFFFFFFF, .Community = 0xFFFFFFFF, .MmioAddr = 0xFFFFFFFF, .Misc = 0xFFFFFFFF },
line over 80 characters



-- 
To view, visit https://review.coreboot.org/23027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00ff95313d74091e7411f6c8658d0d560a0e682b
Gerrit-Change-Number: 23027
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Piotr Król <piotr.krol at 3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Martin Roth <martinroth at google.com>
Gerrit-CC: Michał Żygowski <michal.zygowski at 3mdeb.com>
Gerrit-Comment-Date: Thu, 20 Sep 2018 09:38:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/4d5ac4d1/attachment.html>


More information about the coreboot-gerrit mailing list