[coreboot-gerrit] Change in coreboot[master]: mb/google/poppy/variant/nocturne: set DMIC1 to NC

Nick Vaccaro (Code Review) gerrit at coreboot.org
Thu Sep 20 02:18:08 CEST 2018


Nick Vaccaro has uploaded this change for review. ( https://review.coreboot.org/28689


Change subject: mb/google/poppy/variant/nocturne: set DMIC1 to NC
......................................................................

mb/google/poppy/variant/nocturne: set DMIC1 to NC

Change GPP_D17 and GPP_D18 to no connects as DMIC was moved
to DMIC0.

BUG=b:113744731,b:111106010
TEST=none

Change-Id: I8ef42627e542182707c81389af9da33a114bc184
Signed-off-by: Nick Vaccaro <nvaccaro at google.com>
---
M src/mainboard/google/poppy/variants/nocturne/gpio.c
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/28689/1

diff --git a/src/mainboard/google/poppy/variants/nocturne/gpio.c b/src/mainboard/google/poppy/variants/nocturne/gpio.c
index 08bb801..15a97c3 100644
--- a/src/mainboard/google/poppy/variants/nocturne/gpio.c
+++ b/src/mainboard/google/poppy/variants/nocturne/gpio.c
@@ -195,10 +195,10 @@
 	PAD_CFG_GPO(GPP_D15, 0, DEEP),
 	/* D16 : ISH_UART0_CTS# ==> RCAM_RST_L */
 	PAD_CFG_GPO(GPP_D16, 0, DEEP),
-	/* D17 : DMIC_CLK1 ==> PCH_DMIC_CLK */
-	PAD_CFG_NF(GPP_D17, NONE, DEEP, NF1),
-	/* D18 : DMIC_DATA1 ==> PCH_DMIC_DATA */
-	PAD_CFG_NF(GPP_D18, NONE, DEEP, NF1),
+	/* D17 : DMIC_CLK1 ==> EC_PCH_ARCORE_INT_L */
+	PAD_CFG_NC(GPP_D17),
+	/* D18 : DMIC_DATA1 ==> TP131 */
+	PAD_CFG_NC(GPP_D18),
 	/* D19 : DMIC_CLK0 ==> PCH_DMIC_CLK_OUT */
 	PAD_CFG_NF(GPP_D19, NONE, DEEP, NF1),
 	/* D20 : DMIC_DATA0 ==> PCH_DMIC_DATA_IN */

-- 
To view, visit https://review.coreboot.org/28689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8ef42627e542182707c81389af9da33a114bc184
Gerrit-Change-Number: 28689
Gerrit-PatchSet: 1
Gerrit-Owner: Nick Vaccaro <nvaccaro at google.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180920/c328d417/attachment.html>


More information about the coreboot-gerrit mailing list