[coreboot-gerrit] Change in coreboot[master]: src/lib/edid: avoid buffer overflow

Julius Werner (Code Review) gerrit at coreboot.org
Tue Sep 18 21:56:39 CEST 2018


Julius Werner has posted comments on this change. ( https://review.coreboot.org/28659 )

Change subject: src/lib/edid: avoid buffer overflow
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

LGTM although I think you're off by one.

https://review.coreboot.org/#/c/28659/1/src/lib/edid.c
File src/lib/edid.c:

https://review.coreboot.org/#/c/28659/1/src/lib/edid.c@178
PS1, Line 178:  + 1
Why the +1?



-- 
To view, visit https://review.coreboot.org/28659
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3934bd6965318cdffe5c636b01b3e0c4426e8d1d
Gerrit-Change-Number: 28659
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi at google.com>
Gerrit-Reviewer: Julius Werner <jwerner at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Sep 2018 19:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180918/26ce9b7b/attachment.html>


More information about the coreboot-gerrit mailing list