[coreboot-gerrit] Change in coreboot[master]: mb/clevo/n130wu: Add mainboard

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Tue Sep 18 04:38:27 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28640 )

Change subject: mb/clevo/n130wu: Add mainboard
......................................................................


Patch Set 5:

(4 comments)

https://review.coreboot.org/#/c/28640/5/src/mainboard/clevo/n130wu/gpio.h
File src/mainboard/clevo/n130wu/gpio.h:

https://review.coreboot.org/#/c/28640/5/src/mainboard/clevo/n130wu/gpio.h@111
PS5, Line 111: /* ISH_UART0_RXD/SML0BDATA/I2C4B_SDA */_PAD_CFG_STRUCT(GPP_D13, 0x44000200, 0x0),
line over 80 characters


https://review.coreboot.org/#/c/28640/5/src/mainboard/clevo/n130wu/gpio.h@112
PS5, Line 112: /* ISH_UART0_TXD/SML0BCLK/I2C4B_SCL */ _PAD_CFG_STRUCT(GPP_D14, 0x44000200, 0x0),
line over 80 characters


https://review.coreboot.org/#/c/28640/5/src/mainboard/clevo/n130wu/gpio.h@113
PS5, Line 113: /* ISH_UART0_RTS# */                   _PAD_CFG_STRUCT(GPP_D15, 0x44000700, 0x0),
line over 80 characters


https://review.coreboot.org/#/c/28640/5/src/mainboard/clevo/n130wu/gpio.h@114
PS5, Line 114: /* ISH_UART0_CTS#/SML0BALERT# */       _PAD_CFG_STRUCT(GPP_D16, 0x44000700, 0x0),
line over 80 characters



-- 
To view, visit https://review.coreboot.org/28640
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I364f5849ef88f43b85efbd7a635a27e54d08c513
Gerrit-Change-Number: 28640
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Tue, 18 Sep 2018 02:38:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180918/586ab705/attachment.html>


More information about the coreboot-gerrit mailing list