[coreboot-gerrit] Change in coreboot[master]: mainboard/google/kahlee: allow oem.bin file to update smbios

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/28651 )

Change subject: mainboard/google/kahlee: allow oem.bin file to update smbios
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c
File src/mainboard/google/kahlee/variants/baseboard/mainboard.c:

https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@93
PS1, Line 93: const char *smbios_mainboard_manufacturer(void)
ah, it looks like nami already does this. Should we extract the struct and method into a common file?


https://review.coreboot.org/#/c/28651/1/src/mainboard/google/kahlee/variants/baseboard/mainboard.c@111
PS1, Line 111: 
It might be easier to read if you calculated the number of oem_entries and just did a for loop over the count.



-- 
To view, visit https://review.coreboot.org/28651
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I997dc39c7f36f70cf4320ef335831245889eb475
Gerrit-Change-Number: 28651
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Daniel Kurtz <djkurtz at google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Raul Rangel <rrangel at chromium.org>
Gerrit-Reviewer: Simon Glass <sjg at chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 17 Sep 2018 21:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180917/2eb0916d/attachment.html>