[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint: Don't use device_t

build bot (Jenkins) (Code Review) gerrit at coreboot.org
Mon Sep 17 09:24:09 CEST 2018


build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/28641 )

Change subject: sb/intel/lynxpoint: Don't use device_t
......................................................................


Patch Set 3:

(5 comments)

https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/azalia.c
File src/southbridge/intel/lynxpoint/azalia.c:

https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/azalia.c@157
PS3, Line 157: static void azalia_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/azalia.c@158
PS3, Line 158: 				 unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/serialio.c
File src/southbridge/intel/lynxpoint/serialio.c:

https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/serialio.c@240
PS3, Line 240: static void serialio_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/smbus.c
File src/southbridge/intel/lynxpoint/smbus.c:

https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/smbus.c@73
PS3, Line 73: static void smbus_set_subsystem(struct device *dev, unsigned vendor,
Prefer 'unsigned int' to bare use of 'unsigned'


https://review.coreboot.org/#/c/28641/3/src/southbridge/intel/lynxpoint/smbus.c@74
PS3, Line 74: 				unsigned device)
Prefer 'unsigned int' to bare use of 'unsigned'



-- 
To view, visit https://review.coreboot.org/28641
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I515b9e388dd2c1d1a9f4a24b2966a4b4656965a7
Gerrit-Change-Number: 28641
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes HAOUAS <ehaouas at noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Mon, 17 Sep 2018 07:24:09 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180917/9fc6f407/attachment.html>


More information about the coreboot-gerrit mailing list