[coreboot-gerrit] Change in coreboot[master]: mb/lenovo/x200: Use lower C-states on battery

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22932 )

Change subject: mb/lenovo/x200: Use lower C-states on battery
......................................................................


Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/22932/12/src/arch/x86/include/arch/acpigen.h
File src/arch/x86/include/arch/acpigen.h:

https://review.coreboot.org/#/c/22932/12/src/arch/x86/include/arch/acpigen.h@354
PS12, Line 354: int get_bat_cst_entries(acpi_cstate_t **);
function definition argument 'acpi_cstate_t **' should also have an identifier name


https://review.coreboot.org/#/c/22932/12/src/cpu/intel/speedstep/acpi.c
File src/cpu/intel/speedstep/acpi.c:

https://review.coreboot.org/#/c/22932/12/src/cpu/intel/speedstep/acpi.c@187
PS12, Line 187: 								num_bat_cstates);
line over 80 characters



-- 
To view, visit https://review.coreboot.org/22932
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf32ee2ac3272fee74ce3b92b2c537cb722991d7
Gerrit-Change-Number: 22932
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Duncan Laurie <dlaurie at gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan at google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter at users.sourceforge.net>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer at coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-Comment-Date: Sun, 16 Sep 2018 14:47:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180916/0f015612/attachment.html>