[coreboot-gerrit] Change in coreboot[master]: mb/asrock/g41m_vs3_r2: Add mainboard

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/28596 )

Change subject: mb/asrock/g41m_vs3_r2: Add mainboard
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/28596/5/src/mainboard/asrock/g41c-gs/gpio.c
File src/mainboard/asrock/g41c-gs/gpio.c:

https://review.coreboot.org/#/c/28596/5/src/mainboard/asrock/g41c-gs/gpio.c@75
PS5, Line 75: #if IS_ENABLED(CONFIG_BOARD_ASROCK_G41M_VS3_R2_0)
            : 	.gpio8 = GPIO_LEVEL_LOW,
            : 	.gpio9 = GPIO_LEVEL_LOW,
            : #endif
this IS_ENABLED(CONFIG_BOARD_ASROCK_G41M_VS3_R2_0) is always false, since it's inside the IS_ENABLED(CONFIG_BOARD_ASROCK_G41C_GS_R2_0) block and only one board is or at least should be selected at a time



-- 
To view, visit https://review.coreboot.org/28596
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibce9ecdc0e44db3703401f116c9a8bff5b66437f
Gerrit-Change-Number: 28596
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur at aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus at gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Sun, 16 Sep 2018 10:59:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180916/57822de0/attachment.html>