[coreboot-gerrit] Change in coreboot[master]: Add support for Sunsetrise Point LP to inteltool

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/28623 )

Change subject: Add support for Sunsetrise Point LP to inteltool
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/28623/1/util/inteltool/inteltool.h
File util/inteltool/inteltool.h:

https://review.coreboot.org/#/c/28623/1/util/inteltool/inteltool.h@148
PS1, Line 148: SUNRISEPOINT_LP
the device name in the datasheet is "PCH-U with iHDCP 2.2 Premium", so just SUNRISEPOINT_LP isn't specific enough. See https://www.intel.com/content/dam/www/public/us/en/documents/datasheets/7th-gen-core-family-mobile-u-y-processor-lines-i-o-datasheet-vol-1.pdf page 23. Would also be good if you add all PCI IDs of the LPC controllers of the PCH SKUs. The PCI ID of the LPC controller is the way to identify the different SKUs. Maybe also try to coordinate the patch with #28618



-- 
To view, visit https://review.coreboot.org/28623
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16237ffc9a225b46271f2a51d77a7f28dfc36138
Gerrit-Change-Number: 28623
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <migy at darmstadt.ccc.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Comment-Date: Sun, 16 Sep 2018 10:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180916/03760718/attachment.html>