[coreboot-gerrit] Change in coreboot[master]: soc/sifive: move ram_resource to mainboard

Philipp Hug (Code Review) gerrit at coreboot.org
Sat Sep 15 15:32:27 CEST 2018


Philipp Hug has uploaded this change for review. ( https://review.coreboot.org/28621


Change subject: soc/sifive: move ram_resource to mainboard
......................................................................

soc/sifive: move ram_resource to mainboard

ram_resource is board specific and should be moved there.

Change-Id: I50bd9aaaae39422e565d8bf205a6365c59299df0
Signed-off-by: Philipp Hug <philipp at hug.cx>
---
M src/mainboard/sifive/hifive-unleashed/mainboard.c
D src/soc/sifive/fu540/soc.c
2 files changed, 5 insertions(+), 23 deletions(-)



  git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/28621/1

diff --git a/src/mainboard/sifive/hifive-unleashed/mainboard.c b/src/mainboard/sifive/hifive-unleashed/mainboard.c
index e7f7a40..baf44d4 100644
--- a/src/mainboard/sifive/hifive-unleashed/mainboard.c
+++ b/src/mainboard/sifive/hifive-unleashed/mainboard.c
@@ -13,12 +13,14 @@
  * GNU General Public License for more details.
  */
 
-#include <device/device.h>
-#include <bootblock_common.h>
-#include <timestamp.h>
+#include <arch/io.h>
+#include <console/console.h>
+#include <soc/sdram.h>
+#include <symbols.h>
 
 static void mainboard_enable(struct device *dev)
 {
+	ram_resource(dev, 0, (uintptr_t)_dram/KiB, sdram_size_mb()*KiB);
 }
 
 struct chip_operations mainboard_ops = {
diff --git a/src/soc/sifive/fu540/soc.c b/src/soc/sifive/fu540/soc.c
deleted file mode 100644
index 9405755..0000000
--- a/src/soc/sifive/fu540/soc.c
+++ /dev/null
@@ -1,20 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * Copyright 2018 Philipp Hug <philipp at hug.cx>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-static void soc_enable(struct device *dev)
-{
-	ram_resource(dev, 0, (uintptr_t)_dram/KiB,
-		sdram_size_mb()*KiB);
-}

-- 
To view, visit https://review.coreboot.org/28621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50bd9aaaae39422e565d8bf205a6365c59299df0
Gerrit-Change-Number: 28621
Gerrit-PatchSet: 1
Gerrit-Owner: Philipp Hug <philipp at hug.cx>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180915/e0080a3d/attachment.html>


More information about the coreboot-gerrit mailing list