[coreboot-gerrit] Change in coreboot[master]: arch/x86/acpigen: Fix comment in _ROM method generator
Felix Held (Code Review)
gerrit at coreboot.org
Fri Sep 14 22:18:21 CEST 2018
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/28591 )
Change subject: arch/x86/acpigen: Fix comment in _ROM method generator
......................................................................
arch/x86/acpigen: Fix comment in _ROM method generator
Commit 24462e6507 ("x86/acpigen: Fix ACPI _ROM method") changed the code
to generate a serialized method, but didn't adjust the comment.
Change-Id: Ie7dbaff13d36f31e9d627609d0f74a4e9fa5a1e9
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Reviewed-on: https://review.coreboot.org/28591
Tested-by: build bot (Jenkins) <no-reply at coreboot.org>
Reviewed-by: Martin Roth <martinroth at google.com>
---
M src/arch/x86/acpigen.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Martin Roth: Looks good to me, approved
diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index e10d307..a630ef2 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -1453,7 +1453,7 @@
ASSERT(bios)
ASSERT(length)
- /* Method (_ROM, 2, NotSerialized) */
+ /* Method (_ROM, 2, Serialized) */
acpigen_write_method_serialized("_ROM", 2);
/* OperationRegion("ROMS", SYSTEMMEMORY, current, length) */
--
To view, visit https://review.coreboot.org/28591
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie7dbaff13d36f31e9d627609d0f74a4e9fa5a1e9
Gerrit-Change-Number: 28591
Gerrit-PatchSet: 3
Gerrit-Owner: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Gerrit-Reviewer: Felix Held <felix-coreboot at felixheld.de>
Gerrit-Reviewer: Marc Jones <marc at marcjonesconsulting.com>
Gerrit-Reviewer: Martin Roth <martinroth at google.com>
Gerrit-Reviewer: Patrick Rudolph <siro at das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply at coreboot.org>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.coreboot.org/pipermail/coreboot-gerrit/attachments/20180914/13becaea/attachment.html>
More information about the coreboot-gerrit
mailing list